Overhaul docs tone guidance and rewrite platform overview as example - #606
Conversation
Expand the AGENTS.md Voice & tone section with concrete anti-AI-slop rules modeled on the GitHub and Vercel docs: define-show-link pattern, document the user-visible model (not internal architecture), words to avoid, structural patterns to avoid, and a stricter callout budget (never consecutive, at most one per section). Propagate the rules to the drafting/review workflow: - draft_docs: tone bullets in critical rules + checklist - review-docs-pr: tone/AI-ism review focus item - style_lint: report-only tone checks (tone-buzzword, tone-meta-opener, callout-consecutive, callout-density), never auto-fixed - oz-style-guidelines: align voice section; fix stale 'Ask Oz to...' preferred phrases from before the Automation Platform rename Rewrite platform/overview.mdx as the example page: user-visible model instead of orchestrator/control-plane internals, one callout instead of five, ~65% shorter. Fix the one anchor that pointed at the renamed section (environments.mdx: #execution-hosts -> #hosts). Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR was generated with Warp. Comment |
|
Your GitHub account is not connected to Warp. Connect it here. |
The tone rewrite over-cut: trigger context, the Warp-vs-customer infrastructure diagram, API/SDK team use cases, the integration setup pointer, and cloud provider credentials had no equivalent on linked pages. Restore them in the new style. Details that live on dedicated pages (when to use environments, task states, CLI command reference) stay linked instead of restated. Co-Authored-By: Warp <agent@warp.dev>
warp-factory-examples #10 (plain-language pass) and #11 (follow-up trims from human review) surfaced patterns the tone section didn't cover yet: - Relocate, don't delete: detail in the wrong register (provenance, pinned versions, maintainer process) moves to the surface whose audience needs it, with a pointer, instead of being cut outright. - Say it once, across pages: shared boilerplate lives on the parent or reference page, not repeated on every sibling. - Keep the author out of it: no self-commentary, rules stated calmly without defensive emphasis, describe the present rather than weaving rename history through pages. - Slashed shorthand reads as notes, not prose. - Cut again: a plain-language rewrite under-cuts on the first pass; follow with a deletion-only pass. #11 existed because human review asked for more cutting after #10 had already landed. Also adds the second-pass and relocation items to the draft_docs checklist. Co-Authored-By: Warp <agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR expands the docs tone guidance, adds report-only tone checks to style_lint, and rewrites the Automation Platform overview as an example of the new style. The content changes are generally coherent, and I did not find security issues or spec drift, but the new lint behavior is enabled without durable regression coverage.
Concerns
- The new
style_linttone checks are wired into every scan without tests for the matching and exclusion behavior. Existing lint rules in this repository have focusedtest_*.pyregression scripts, and these regex-heavy checks need the same coverage before they start affecting docs review automation.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
I think these changes are really valuable! A couple of things we might add, all on the brevity side.
Every new rule targets words and sentences. Nothing targets page length, which would be a useful thing to check against.
The section that owns length is untouched and prescribes the opposite remedy:
AGENTS.mdL230: "If a page exceeds ~1500 words, consider breaking it into sub-pages or using clear anchor links."
Splitting a bloated page gives you two bloated pages. Suggest: cut first, split only if it's still long, with a pointer to "Cut again."
Some other thoughts:
-
AGENTS.md's own quality checklist got nothing.draft_docsgained 4 tone/brevity items; theAGENTS.mdchecklist (L900-916) gained zero. That checklist is the authority this PR keeps pointing at, and the two have now diverged. -
7 of 8 page templates carry no brevity guidance. Templates are where drafting starts, and one listing sections invites filling every one. Worth an explicit "delete any section you don't need; a short page is a finished page." (Also true of my template rewrite in #586 — shared gap, not yours.)
-
4 per-type drafting skills have no tone/brevity mention:
draft_conceptual,draft_quickstart,draft_troubleshooting,draft_feature_doc.draft_quickstartis the sharpest miss — quickstarts have a hard ~600-word budget and it's the one type where length is the constraint.
Note for posterity: there's a small conflict with #586.
CONFLICT (content): Merge conflict in .agents/skills/draft_docs/SKILL.md
Both PRs add bullets to the same "Critical formatting rules" list and the same checklist. AGENTS.md merges clean. Small, but shouldn't be auto-resolved — both sets should survive.
Addresses Rachael's review comments on PR #606 and applies a broader polish pass on the same change: - style_lint: add the missing filler frames (designed to, ensures that, allows you to, in order to) and abstract-dramatics words (landscape, realm) to the tone-buzzword check, and add test_tone_checks.py regression coverage for the three tone checks (tone-buzzword, tone-meta-opener, callout-density/consecutive), which previously shipped without tests. - oz-style-guidelines.md: add a Don't against stacking an em dash and a colon in the same sentence. - review-docs-pr: add a length/brevity review item so a reviewing agent catches an oversized page, not just isolated buzzwords. - AGENTS.md: fix the page-length guidance to "cut first, split only if it's still long" (it previously told authors to split first, contradicting the new tone guidance), and sync the canonical Quality checklist with the tone/brevity items draft_docs already carries. - Extend the brevity guidance to the rest of the drafting surface: add an explicit "delete any section you don't need" instruction to the 7 page templates that lacked one, and a tone/brevity rule to draft_conceptual, draft_quickstart (explicit ~600-word budget), draft_troubleshooting, and draft_feature_doc. Co-Authored-By: Warp <agent@warp.dev>
|
Thanks for the review — addressed the inline comments individually (see replies on each thread). Responding here to the broader points in your review summary, in the same order:
Also did a general polish pass while in here: expanded the tone-buzzword lint list (the four missing filler frames plus |
There was a problem hiding this comment.
Overview
Confirmed Rachael's review comments, the tone and brevity polish pass, and the refreshed visual verification for the rewritten platform overview.
Verdict
Checks: CI ✅ · build ✅ · style-lint suites ✅ · internal links ✅ · visual proof ✅
Found: 0 critical, 0 important, 0 suggestions
Approve
Review run
https://oz.staging.warp.dev/runs/01a0303a-2b51-7324-b052-a5e9ca654760


What this does
Makes the docs sound like they were written by a person, using the GitHub and Vercel docs as the reference tone. Three parts: expanded tone guidance, enforcement in the drafting/review/lint workflow, and one example page rewritten to demonstrate the target.
1. Tone guidance (
AGENTS.md)The Voice & tone section grows from 5 bullets to a full set of rules with before/after examples pulled from our own pages:
.agents/rules/oz-style-guidelines.mdis aligned with the new rules and its stale pre-rename "Ask Oz to..." preferred phrases are fixed.2. Enforcement
draft_docsskill: tone bullets in the critical rules and the pre-publish checklist.review-docs-prskill: a tone/AI-ism review focus item.style_lint: four report-only checks, never auto-fixed:tone-buzzword,tone-meta-opener,callout-consecutive,callout-density. Words with legitimate uses here (harness, unlock, elevated, journey) are deliberately excluded from the lint. Current baseline across the docs: ~27 pages with buzzwords, 43 meta-openers.3. Example rewrite:
platform/overview.mdxModeled on GitHub's "Understanding GitHub Actions": lead with what you can do, define each primitive in a few plain sentences, link out for depth.
environments.mdx:#execution-hosts→#hosts).Follow-ups (not in this PR)
platform/environments.mdx(9 callouts, a verbatim duplicated sentence) andplatform/integrations/github-actions.mdx("integrates seamlessly", consecutive callouts) are the next rewrite candidates.Rework changes
Addressed Rachael's review comments and did a broader polish pass on the same diff:
style_lint: added the 4 missing filler frames (designed to,ensures that,allows you to,in order to) and 2 missing abstract-dramatics words (landscape,realm) to thetone-buzzwordcheck, plus a newtest_tone_checks.pyregression suite covering all three previously-untested tone checks (tone-buzzword,tone-meta-opener,callout-density/callout-consecutive).oz-style-guidelines.md: added a Don't against stacking an em dash and a colon in the same sentence.review-docs-pr: added a length/brevity review item so a reviewing agent flags an oversized page, not just isolated buzzwords.AGENTS.md: fixed the page-length guidance to "cut first, split only if it's still long" (previously contradicted the new tone guidance by telling authors to split first), and synced the canonical Quality checklist with the tone/brevity itemsdraft_docsalready carries.draft_conceptual,draft_quickstart(explicit ~600-word budget),draft_troubleshooting, anddraft_feature_doc./platform/overview/page (top: H1, opening paragraph, Note callout; bottom: Secrets/Shared configuration/Warp Factories/Where to go next) confirming the rewrite renders cleanly with no layout or content issues. See the screenshot block below and the linked ticket comment.Validation
npm run buildpasses (376 pages).style_lintregression suites pass (11/11 platform-determiner, 21/21 factory-proper-noun, 6/6 hardcoded-var-exemptions, 23/23 tone-checks); the rewritten overview passes the full lint with 0 issues; new tone checks verified to fire on known-bad pages.Computer-use screenshots (2)
Top of the /platform/overview/ page showing the H1 "Automation Platform overview", opening paragraph, and a blue Note callout box about "Oz is now the Automation Platform"
Bottom of the /platform/overview/ page showing Secrets, Shared configuration, Warp Factories, and Where to go next sections with a bullet list of links, plus the page footer navigation