Skip to content

Better unicode handling#282

Merged
waf merged 3 commits into
mainfrom
better-unicode-handling
May 31, 2026
Merged

Better unicode handling#282
waf merged 3 commits into
mainfrom
better-unicode-handling

Conversation

@waf
Copy link
Copy Markdown
Owner

@waf waf commented May 31, 2026

Character navigation / rendering / clipboard fixes for unicode characters.

Drops the wcwidth implementation and use https://github.com/spectreconsole/wcwidth (source-only package) instead.

This fixes a whole host of issues around emojis + zero-width-joiners

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

❌ Patch coverage is 84.54545% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.7%. Comparing base (cc3f42a) to head (3cda2a3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/PrettyPrompt/Documents/Grapheme.cs 80.0% 2 Missing and 4 partials ⚠️
src/PrettyPrompt/Rendering/Screen.cs 53.8% 3 Missing and 3 partials ⚠️
src/PrettyPrompt/Rendering/UnicodeWidth.cs 80.0% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #282     +/-   ##
=======================================
- Coverage   85.0%   84.7%   -0.4%     
=======================================
  Files         46      47      +1     
  Lines       3943    3908     -35     
  Branches     603     612      +9     
=======================================
- Hits        3353    3311     -42     
- Misses       448     452      +4     
- Partials     142     145      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@waf waf merged commit 9dded14 into main May 31, 2026
2 checks passed
@waf waf deleted the better-unicode-handling branch May 31, 2026 02:42
@waf waf mentioned this pull request May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant