Skip to content

Conversation

@zhiyuanzmj
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 15, 2026 11:08
@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.5 kB 30 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.7 kB 36.6 kB
vue.global.prod.js 167 kB 60.8 kB 54.2 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.3 kB 18.9 kB 17.3 kB
createApp 57.3 kB 22 kB 20.1 kB
createApp + vaporInteropPlugin 86.2 kB 32.1 kB 28.9 kB
createVaporApp 27.9 kB 10.7 kB 9.83 kB
createSSRApp 61.6 kB 23.9 kB 21.7 kB
defineCustomElement 63.3 kB 23.9 kB 21.8 kB
overall 72.1 kB 27.3 kB 24.9 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 15, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14324
npm i https://pkg.pr.new/@vue/compiler-core@14324
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14324
npm i https://pkg.pr.new/@vue/compiler-dom@14324
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14324
npm i https://pkg.pr.new/@vue/compiler-sfc@14324
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14324
npm i https://pkg.pr.new/@vue/compiler-ssr@14324
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14324
npm i https://pkg.pr.new/@vue/compiler-vapor@14324
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14324
npm i https://pkg.pr.new/@vue/reactivity@14324
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14324
npm i https://pkg.pr.new/@vue/runtime-core@14324
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14324
npm i https://pkg.pr.new/@vue/runtime-dom@14324
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14324
npm i https://pkg.pr.new/@vue/runtime-vapor@14324
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14324
npm i https://pkg.pr.new/@vue/server-renderer@14324
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14324
npm i https://pkg.pr.new/@vue/shared@14324
yarn add https://pkg.pr.new/@vue/[email protected]

vue

pnpm add https://pkg.pr.new/vue@14324
npm i https://pkg.pr.new/vue@14324
yarn add https://pkg.pr.new/[email protected]

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14324
npm i https://pkg.pr.new/@vue/compat@14324
yarn add https://pkg.pr.new/@vue/[email protected]

commit: c218f00

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused JSX-related code from the compiler-vapor package. The jsx property was never actually used in the codebase, making it dead code that can be safely removed.

Changes:

  • Removed the jsx property from the SetTextIRNode interface
  • Simplified the genSetText and combineValues functions by removing the unused jsx parameter
  • Cleaned up conditional logic that previously checked for JSX mode

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/compiler-vapor/src/ir/index.ts Removed unused jsx property from SetTextIRNode interface
packages/compiler-vapor/src/generators/text.ts Removed jsx parameter from functions and simplified text value combination logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant