-
-
Notifications
You must be signed in to change notification settings - Fork 9k
refactor(compiler-vapor): remove JSX #14324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes unused JSX-related code from the compiler-vapor package. The jsx property was never actually used in the codebase, making it dead code that can be safely removed.
Changes:
- Removed the
jsxproperty from theSetTextIRNodeinterface - Simplified the
genSetTextandcombineValuesfunctions by removing the unusedjsxparameter - Cleaned up conditional logic that previously checked for JSX mode
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compiler-vapor/src/ir/index.ts | Removed unused jsx property from SetTextIRNode interface |
| packages/compiler-vapor/src/generators/text.ts | Removed jsx parameter from functions and simplified text value combination logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.