chore: suppress warnings from DuckDB headers#6909
Merged
Conversation
…S_BEGIN/END Add duckdb_diagnostics.h with push/pop diagnostic macros that suppress -Wall, -Wextra, and -Wpedantic warnings from DuckDB headers we include but do not own. Works on both GCC and Clang via #pragma GCC diagnostic. Wrap all DuckDB #include directives across headers and source files with the new macros, and remove the now-unnecessary global -Wno-unused-parameter flag from build.rs. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Remove parameter names (keeping types) for unused callback parameters that must match DuckDB's required function signatures. This is the standard C++ idiom for suppressing unused-parameter warnings without altering the function signature. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1
changed the title
robert3005
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push/pop diagnostics to suppress warnings from DuckDB headers we include but do not own. Works on both GCC and Clang via #pragma GCC diagnostic.