Merged
Conversation
joseph-isaacs
force-pushed
the
ji/ngates/exeution-3
branch
2 times, most recently
from
0bcdf7d to
68dde3b
Compare
Merging this PR will degrade performance by 34.14%
Performance ChangesComparing 
Footnotes
|
gatesn
approved these changes
Mar 9, 2026
joseph-isaacs
added
changelog/feature
github-actions
bot
removed
the
action/benchmark
robert3005
approved these changes
Mar 9, 2026
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
I think we need a lighter way of replacing children, with_child feels like a costly method
Adds a method to replace a single child of an array by index, building on the existing with_children infrastructure. This is needed by the upcoming iterative execution scheduler which replaces children one at a time as they are executed. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds the ExecutionStep enum (ExecuteChild, ColumnarizeChild, Done) that encodings will return from VTable::execute instead of ArrayRef. This is infrastructure for the upcoming iterative execution scheduler. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…duler Changes the VTable::execute signature to return ExecutionStep instead of ArrayRef, and replaces the Executable for Columnar implementation with an iterative work-stack scheduler. The ExecutionStep enum has three variants: - ExecuteChild(i): ask the scheduler to execute child i to columnar - ColumnarizeChild(i): same but skip cross-step optimization - Done(result): execution complete The new scheduler in Executable for Columnar uses an explicit stack instead of recursion, and runs reduce/reduce_parent rules between steps via the existing optimizer infrastructure. All encoding implementations are mechanically wrapped in ExecutionStep::Done(...) to preserve existing behavior. Individual encodings will be migrated to use ExecuteChild/ColumnarizeChild in follow-up PRs. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move the iterative execution scheduler into a general-purpose `execute_until<M: Matcher>` method on `dyn Array`. The scheduler terminates when the root array matches `M`, while each child can specify its own termination condition via a `DonePredicate` carried in `ExecutionStep::ExecuteChild`. `ExecutionStep` now provides constructor methods: - `execute_child::<M>(idx)` — request child execution until M matches - `done(result)` — signal completion Both `Executable for Columnar` and `Executable for Canonical` are simplified to thin wrappers over `execute_until` with `AnyColumnar` and `AnyCanonical` matchers respectively. Signed-off-by: Nick Gates <nick@vortex.dev> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
joseph-isaacs
force-pushed
the
ji/ngates/exeution-3
branch
from
22ed980 to
37929f1
Compare
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Closed
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the model of execution from internal iterator to external.
We go from a recursive execution to an iterative execution with a explicit stack and VTable requesting execution on a child.
This can help with stack overflow on high-depth array trees.
Breaks
Changed the execute method. Likely unused externally.
Follow ups: