Skip to content

Self hashjoin SQL test for duckdb-vortex#6769

Merged
myrrc merged 1 commit intodevelopfrom
myrrc/hashjoin-test
Mar 3, 2026
Merged

Self hashjoin SQL test for duckdb-vortex#6769
myrrc merged 1 commit intodevelopfrom
myrrc/hashjoin-test

Conversation

@myrrc
Copy link
Contributor

@myrrc myrrc commented Mar 3, 2026

Testcase which currently breaks #6627

@myrrc myrrc requested a review from 0ax1 March 3, 2026 16:58
@myrrc myrrc added ext/duckdb Relates to the DuckDB integration changelog/skip Do not list PR in the changelog labels Mar 3, 2026
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc force-pushed the myrrc/hashjoin-test branch from 8c17eaa to c1b34f2 Compare March 3, 2026 16:59
Copy link
Contributor

@0ax1 0ax1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one q. was the file supposed to be named hasjoin or hashjoin?

@myrrc myrrc enabled auto-merge (squash) March 3, 2026 17:09
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2026

Merging this PR will improve performance by 12.36%

⚡ 2 improved benchmarks
✅ 952 untouched benchmarks
⏩ 1466 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation map_each[BufferMut<i32>, 128] 858.1 ns 770.6 ns +11.36%
Simulation bitwise_not_vortex_buffer_mut[128] 530.3 ns 471.9 ns +12.36%

Comparing myrrc/hashjoin-test (c1b34f2) with develop (b10b4f4)

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc myrrc merged commit 8d68b78 into develop Mar 3, 2026
55 checks passed
@myrrc myrrc deleted the myrrc/hashjoin-test branch March 3, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants