Skip to content

fix: prevent UnboundLocalError in A2A telemetry and escape SSE error JSON #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WangXukang-cypher wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent UnboundLocalError in A2A telemetry and escape SSE error JSON #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions agentkit/apps/a2a_app/a2a_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ async def wrapper(*args, **kwargs):

with telemetry.tracer.start_as_current_span(name="a2a_invocation") as span:
exception = None
result = None
try:
result = await execute_func(
executor_instance, context=context, event_queue=event_queue
Expand Down
4 changes: 3 additions & 1 deletion agentkit/apps/agent_server_app/agent_server_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,9 @@ async def event_generator():
telemetry.trace_agent_server_finish(
path="/invoke", func_result="", exception=e
)
error_payload = f'data: {{"error": "{str(e)}"}}\n\n'
error_payload = (
"data: " + json.dumps({"error": str(e)}) + "\n\n"
)
if error_payload is not None:
# The identity path never suspends while retaining the
# original exception or its credential-bearing traceback.
Expand Down