fix(napi): return undefined for missing envs#508
Merged
Conversation
3284206 to
87813ee
Compare
Co-authored-by: GPT-5 Codex <codex@openai.com>
87813ee to
5e86972
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Missing env vars requested through
@voidzero-dev/vite-task-clientneed to be exposed as JavaScriptundefined, matching the package contract. The napi binding previously returned RustOption<String>directly, which lets absent values cross the native boundary asnulland can break callers that check specifically forundefined.Changes
Either<String, Undefined>from the napigetEnvbinding so absent envs are created as real JavaScriptundefined.undefinedthrough the public client package.