Skip to content

Remove allowCompoundComponents migration workaround after upstream support #2703

Description

@fengmk2

PR #2702 adds a temporary migration workaround for eslint-plugin-react-refresh@0.5.7. Its Vite preset enables allowCompoundComponents. @oxlint/migrate@1.82.0 copies this option to react/only-export-components, but the bundled Oxlint rejects it. Migration therefore removes the option from root and override rules and warns the user.

Remove this workaround when the bundled @oxlint/migrate and Oxlint support the option end to end. Migrator support alone is insufficient if Oxlint still rejects the generated configuration. The final behavior must preserve allowCompoundComponents and accept the migrated configuration in vp check.

  • Update the bundled dependencies to versions that support allowCompoundComponents.
  • Remove stripUnsupportedReactRefreshOption, its root and override calls, and the related warning from packages/cli/src/migration/migrator/eslint.ts.
  • Replace the temporary schema guard and option-removal assertions in packages/cli/src/migration/__tests__/react-refresh-options.spec.ts with coverage that preserves the option in root and override rules without a warning.
  • Update the new_create_vite_migrates_eslint_prettier snapshot to retain the supported option. Keep its vp check step and confirm that the generated React TypeScript project accepts the configuration.

The schema guard in #2702 will fail when the installed Oxlint schema gains the option, so the workaround is reviewed during the dependency update.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Fields

Priority

None yet

Effort

None yet

Target date

None yet

Start date

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions