feat: expose WindowCfg.sample_count (MSAA) and forward to gg.new_context#61
Open
MartenH wants to merge 1 commit into
Open
feat: expose WindowCfg.sample_count (MSAA) and forward to gg.new_context#61MartenH wants to merge 1 commit into
MartenH wants to merge 1 commit into
Conversation
gg already supports MSAA via Config.sample_count (and new_context forwards it), but gui hard-codes the default (1 = off) with no way to enable it. Add a sample_count field to WindowCfg (default 1, so it's inert for existing apps) and pass it through to gg.new_context. With sample_count: 4, draw_canvas lines and polygons (e.g. real-time signal plots) render antialiased instead of jagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ggalready supports MSAA throughConfig.sample_count, andgg.new_context()forwards it to sokol — butguihard-codes the default (1= off) and gives apps no way to turn it on.This adds a
sample_countfield toWindowCfg(default1, so it's a no-op for every existing app) and forwards it togg.new_context():With
sample_count: 4,draw_canvaslines/polygons (e.g. real-time signal plots) render antialiased instead of jagged. No behaviour change unless an app opts in.v fmt-clean; two added lines (the field + the pass-through).