Skip to content

[Fix] DNS Providers: edit dialog fields never prefilled - #1225

Merged
RichardAnderson merged 2 commits into
vitodeploy:4.xfrom
RichardAnderson:fix/dns-providers
Aug 2, 2026
Merged

[Fix] DNS Providers: edit dialog fields never prefilled#1225
RichardAnderson merged 2 commits into
vitodeploy:4.xfrom
RichardAnderson:fix/dns-providers

Conversation

@RichardAnderson

@RichardAnderson RichardAnderson commented Aug 2, 2026

Copy link
Copy Markdown
Member

The DNS providers table never sent editable_data to the client, so every provider-registered edit field rendered blank instead of prefilled - this adds the column (guarded so a provider whose plugin was removed no longer crashes the page or the API).

Summary by CodeRabbit

  • Improvements

    • DNS provider entries now include the information required for editing and deleting providers.
    • Sensitive tokens are excluded from data exposed to the interface.
    • The DNS provider list continues to load successfully when a provider’s handler is no longer available.
  • Bug Fixes

    • Improved reliability when displaying and managing DNS providers with unavailable integrations.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e9362c41-c28f-4d16-8e2d-e9c674b80c63

📥 Commits

Reviewing files that changed from the base of the PR and between 1126b95 and 97a5fa2.

📒 Files selected for processing (1)
  • app/Tables/DnsProviderTable.php

📝 Walkthrough

Walkthrough

The DNS provider index now returns provider metadata and editable data. Feature tests cover editable API URLs, token exclusion, and providers without registered handlers.

Changes

DNS provider editable data

Layer / File(s) Summary
Editable data contract and coverage
tests/Feature/DNSProvidersTest.php
Adds a test provider with editable API URL data. Tests verify that tokens are excluded and unregistered providers still return successful HTML and JSON responses.
Index data wiring
app/Tables/DnsProviderTable.php, resources/js/pages/dns-providers/index.tsx
Adds editable_data to each table row and preserves provider and editable_data when converting rows to DNSProvider objects.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: saeedvaziry

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: pre-filling edit dialog fields for DNS providers.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RichardAnderson
RichardAnderson merged commit dc75758 into vitodeploy:4.x Aug 2, 2026
6 checks passed
@RichardAnderson
RichardAnderson deleted the fix/dns-providers branch August 2, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants