feat: replace native confirm() with styled delete confirmation modal on Knowledge Base page#49
Open
androemeda wants to merge 1 commit intovirtualcell:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48
Summary
Replaces the native browser
confirm()dialog on the/admin/knowledge-basepage with a styled in-app modal that is consistent with the rest of the UI. The modal displays the filename, a warning that the action cannot be undone, and Cancel / Delete buttons.Explanation of Implementation
showDeleteModal(boolean) andfileToDelete(string | null) — to control the modal.handleDeleteFileto only set state (open the modal) instead of callingconfirm()and making the API call directly.confirmDeletefunction, which is called when the user clicks Delete in the modal.bg-red-100/text-red-600for the icon badge,bg-red-600for the Delete button, andborder-slate-300for Cancel — consistent with theblue-600/slate/red-600palette used throughout the app.Screenshots
Before
After
Testing
/admin/knowledge-baseand click the trash icon — confirm the new modal appears (not a browser alert)