[.github] Point manual-backport instructions at the input the dialog shows - #3720
[.github] Point manual-backport instructions at the input the dialog shows#3720VaguelySerious wants to merge 1 commit into
Conversation
…shows The backport workflow's PR comments told people to "paste this commit SHA into the `ref` input". `ref` is the input's YAML name and appears nowhere in the Run workflow dialog, which labels inputs by their description. The one visibly ref-named control there is "Use workflow from", which selects the branch the workflow file is read from and rejects a raw SHA. Name the field by its visible label instead, and say which control it is not. Also correct what a manual dispatch actually buys you. A forced run skips the AI *decision*; it does not skip AI *conflict resolution*, which runs unconditionally whenever the cherry-pick conflicts. So "once the underlying issue is fixed, re-run" was the wrong advice for the failure that prompted this: every run since 2026-08-21 18:31 died on `API key budget exceeded` from the AI Gateway, including a forced dispatch that resolved its SHA and cherry-picked correctly before hitting the same wall. The failure comment now lists an out-of-budget key among the causes and carries the manual cherry-pick recipe, which previously lived only in the conflict comment that an infra failure never reaches. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 2a2ff2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🧪 E2E Test Results❌ Some tests failed ❌ Failed E2E Tests▲ Vercel Production (251 failed)astro-node (8 failed):
astro-quickjs (11 failed):
example-node (10 failed):
example-quickjs (9 failed):
express-node (7 failed):
express-quickjs (10 failed):
fastify-node (10 failed):
fastify-quickjs (10 failed):
hono-node (9 failed):
hono-quickjs (13 failed):
nest-node (8 failed):
nest-quickjs (10 failed):
nextjs-turbopack-node (4 failed):
nextjs-turbopack-quickjs (10 failed):
nextjs-webpack-node (7 failed):
nextjs-webpack-quickjs (9 failed):
nitro-node (10 failed):
nitro-quickjs (11 failed):
nuxt-node (8 failed):
nuxt-quickjs (11 failed):
python-node (8 failed):
sveltekit-node (8 failed):
sveltekit-quickjs (10 failed):
tanstack-start-node (7 failed):
tanstack-start-quickjs (11 failed):
vite-node (11 failed):
vite-quickjs (11 failed):
🌐 Cross-language Conformance (9 failed)python (9 failed):
|
| Passed | Failed | Skipped | Total | |
|---|---|---|---|---|
| ❌ ▲ Vercel Production | 3327 | 251 | 742 | 4320 |
| ✅ 💻 Local Development | 3922 | 0 | 558 | 4480 |
| ✅ 📦 Local Production | 3922 | 0 | 558 | 4480 |
| ✅ 🐘 Local Postgres | 3922 | 0 | 558 | 4480 |
| ✅ 🪟 Windows | 320 | 0 | 0 | 320 |
| ❌ 🌐 Cross-language Conformance | 0 | 9 | 132 | 141 |
| ✅ vercel-multi-region | 27 | 0 | 0 | 27 |
| Total | 15440 | 260 | 2548 | 18248 |
Details by Category
❌ ▲ Vercel Production
| App | Passed | Failed | Skipped |
|---|---|---|---|
| ❌ astro-node | 124 | 8 | 28 |
| ❌ astro-quickjs | 121 | 11 | 28 |
| ❌ example-node | 122 | 10 | 28 |
| ❌ example-quickjs | 123 | 9 | 28 |
| ❌ express-node | 125 | 7 | 28 |
| ❌ express-quickjs | 122 | 10 | 28 |
| ❌ fastify-node | 122 | 10 | 28 |
| ❌ fastify-quickjs | 122 | 10 | 28 |
| ❌ hono-node | 123 | 9 | 28 |
| ❌ hono-quickjs | 119 | 13 | 28 |
| ❌ nest-node | 124 | 8 | 28 |
| ❌ nest-quickjs | 122 | 10 | 28 |
| ❌ nextjs-turbopack-node | 153 | 4 | 3 |
| ❌ nextjs-turbopack-quickjs | 147 | 10 | 3 |
| ❌ nextjs-webpack-node | 150 | 7 | 3 |
| ❌ nextjs-webpack-quickjs | 148 | 9 | 3 |
| ❌ nitro-node | 122 | 10 | 28 |
| ❌ nitro-quickjs | 121 | 11 | 28 |
| ❌ nuxt-node | 124 | 8 | 28 |
| ❌ nuxt-quickjs | 121 | 11 | 28 |
| ❌ python-node | 0 | 8 | 152 |
| ❌ sveltekit-node | 143 | 8 | 9 |
| ❌ sveltekit-quickjs | 141 | 10 | 9 |
| ❌ tanstack-start-node | 125 | 7 | 28 |
| ❌ tanstack-start-quickjs | 121 | 11 | 28 |
| ❌ vite-node | 121 | 11 | 28 |
| ❌ vite-quickjs | 121 | 11 | 28 |
✅ 💻 Local Development
| App | Passed | Failed | Skipped |
|---|---|---|---|
| ✅ astro-stable-node | 134 | 0 | 26 |
| ✅ astro-stable-quickjs | 134 | 0 | 26 |
| ✅ express-stable-node | 134 | 0 | 26 |
| ✅ express-stable-quickjs | 134 | 0 | 26 |
| ✅ fastify-stable-node | 134 | 0 | 26 |
| ✅ fastify-stable-quickjs | 134 | 0 | 26 |
| ✅ hono-stable-node | 134 | 0 | 26 |
| ✅ hono-stable-quickjs | 134 | 0 | 26 |
| ✅ nest-stable-node | 134 | 0 | 26 |
| ✅ nest-stable-quickjs | 134 | 0 | 26 |
| ✅ nextjs-turbopack-canary-node | 141 | 0 | 19 |
| ✅ nextjs-turbopack-canary-quickjs | 141 | 0 | 19 |
| ✅ nextjs-turbopack-stable-node | 160 | 0 | 0 |
| ✅ nextjs-turbopack-stable-quickjs | 160 | 0 | 0 |
| ✅ nextjs-webpack-canary-node | 141 | 0 | 19 |
| ✅ nextjs-webpack-canary-quickjs | 141 | 0 | 19 |
| ✅ nextjs-webpack-stable-node | 160 | 0 | 0 |
| ✅ nextjs-webpack-stable-quickjs | 160 | 0 | 0 |
| ✅ nitro-stable-node | 134 | 0 | 26 |
| ✅ nitro-stable-quickjs | 134 | 0 | 26 |
| ✅ nuxt-stable-node | 134 | 0 | 26 |
| ✅ nuxt-stable-quickjs | 134 | 0 | 26 |
| ✅ sveltekit-stable-node | 153 | 0 | 7 |
| ✅ sveltekit-stable-quickjs | 153 | 0 | 7 |
| ✅ tanstack-start-node | 134 | 0 | 26 |
| ✅ tanstack-start-quickjs | 134 | 0 | 26 |
| ✅ vite-stable-node | 134 | 0 | 26 |
| ✅ vite-stable-quickjs | 134 | 0 | 26 |
✅ 📦 Local Production
| App | Passed | Failed | Skipped |
|---|---|---|---|
| ✅ astro-stable-node | 134 | 0 | 26 |
| ✅ astro-stable-quickjs | 134 | 0 | 26 |
| ✅ express-stable-node | 134 | 0 | 26 |
| ✅ express-stable-quickjs | 134 | 0 | 26 |
| ✅ fastify-stable-node | 134 | 0 | 26 |
| ✅ fastify-stable-quickjs | 134 | 0 | 26 |
| ✅ hono-stable-node | 134 | 0 | 26 |
| ✅ hono-stable-quickjs | 134 | 0 | 26 |
| ✅ nest-stable-node | 134 | 0 | 26 |
| ✅ nest-stable-quickjs | 134 | 0 | 26 |
| ✅ nextjs-turbopack-canary-node | 141 | 0 | 19 |
| ✅ nextjs-turbopack-canary-quickjs | 141 | 0 | 19 |
| ✅ nextjs-turbopack-stable-node | 160 | 0 | 0 |
| ✅ nextjs-turbopack-stable-quickjs | 160 | 0 | 0 |
| ✅ nextjs-webpack-canary-node | 141 | 0 | 19 |
| ✅ nextjs-webpack-canary-quickjs | 141 | 0 | 19 |
| ✅ nextjs-webpack-stable-node | 160 | 0 | 0 |
| ✅ nextjs-webpack-stable-quickjs | 160 | 0 | 0 |
| ✅ nitro-stable-node | 134 | 0 | 26 |
| ✅ nitro-stable-quickjs | 134 | 0 | 26 |
| ✅ nuxt-stable-node | 134 | 0 | 26 |
| ✅ nuxt-stable-quickjs | 134 | 0 | 26 |
| ✅ sveltekit-stable-node | 153 | 0 | 7 |
| ✅ sveltekit-stable-quickjs | 153 | 0 | 7 |
| ✅ tanstack-start-node | 134 | 0 | 26 |
| ✅ tanstack-start-quickjs | 134 | 0 | 26 |
| ✅ vite-stable-node | 134 | 0 | 26 |
| ✅ vite-stable-quickjs | 134 | 0 | 26 |
✅ 🐘 Local Postgres
| App | Passed | Failed | Skipped |
|---|---|---|---|
| ✅ astro-stable-node | 134 | 0 | 26 |
| ✅ astro-stable-quickjs | 134 | 0 | 26 |
| ✅ express-stable-node | 134 | 0 | 26 |
| ✅ express-stable-quickjs | 134 | 0 | 26 |
| ✅ fastify-stable-node | 134 | 0 | 26 |
| ✅ fastify-stable-quickjs | 134 | 0 | 26 |
| ✅ hono-stable-node | 134 | 0 | 26 |
| ✅ hono-stable-quickjs | 134 | 0 | 26 |
| ✅ nest-stable-node | 134 | 0 | 26 |
| ✅ nest-stable-quickjs | 134 | 0 | 26 |
| ✅ nextjs-turbopack-canary-node | 141 | 0 | 19 |
| ✅ nextjs-turbopack-canary-quickjs | 141 | 0 | 19 |
| ✅ nextjs-turbopack-stable-node | 160 | 0 | 0 |
| ✅ nextjs-turbopack-stable-quickjs | 160 | 0 | 0 |
| ✅ nextjs-webpack-canary-node | 141 | 0 | 19 |
| ✅ nextjs-webpack-canary-quickjs | 141 | 0 | 19 |
| ✅ nextjs-webpack-stable-node | 160 | 0 | 0 |
| ✅ nextjs-webpack-stable-quickjs | 160 | 0 | 0 |
| ✅ nitro-stable-node | 134 | 0 | 26 |
| ✅ nitro-stable-quickjs | 134 | 0 | 26 |
| ✅ nuxt-stable-node | 134 | 0 | 26 |
| ✅ nuxt-stable-quickjs | 134 | 0 | 26 |
| ✅ sveltekit-stable-node | 153 | 0 | 7 |
| ✅ sveltekit-stable-quickjs | 153 | 0 | 7 |
| ✅ tanstack-start-node | 134 | 0 | 26 |
| ✅ tanstack-start-quickjs | 134 | 0 | 26 |
| ✅ vite-stable-node | 134 | 0 | 26 |
| ✅ vite-stable-quickjs | 134 | 0 | 26 |
✅ 🪟 Windows
| App | Passed | Failed | Skipped |
|---|---|---|---|
| ✅ nextjs-turbopack-node | 160 | 0 | 0 |
| ✅ nextjs-turbopack-quickjs | 160 | 0 | 0 |
❌ 🌐 Cross-language Conformance
| App | Passed | Failed | Skipped |
|---|---|---|---|
| ❌ python | 0 | 9 | 132 |
✅ vercel-multi-region
| App | Passed | Failed | Skipped |
|---|---|---|---|
| ✅ nextjs-turbopack | 27 | 0 | 0 |
📊 Workflow Benchmarkscommit Backend:
Streams
📈 STSO distribution vs main (inline / queue-hop histograms)1020 steps (inline) Cumulative STSO time: main 231540ms → this run 165714ms (Δ -65826ms, -28%) 📈 CRTT drill-down vs main (RTT distributions & profiles)RTT over stream progress (avg per tenth of stream, bars scaled min→max): RTT by chunk size (avg per log size bin, ~160B → ~12KB serialized, bars scaled min→max): Delivery jitter over stream progress (avg positive CDV per tenth of stream, bars scaled min→max): ℹ️ Metric definitions & methodologyStreams: first-chunk RTT (the stream-open path, before any buffering/backpressure), CRTT percentiles, and worst delivery stall (CDV max). Cells are medians across iterations; per-run values in the artifacts. No 🔴/🟢 marks until targets attach. The collapsed STSO distribution section above buckets every step gap, split inline (same warm process — pure framework overhead) vs queue-hop (fresh process — dispatch, reinit, replay). The collapsed CRTT drill-down: per-variant RTT histograms (fixed log bins, Best/P75/P90/P99 deltas compare against the most recent benchmark run on Metrics — TTFS: time to first step body (in-deployment start() → first step body) · Fan-out TTFS: fan-out time to first step (in-deployment start() → first of the parallel step bodies to complete) · Fan-out TTLS: fan-out time to last step (in-deployment start() → last of the parallel step bodies to complete, i.e. when the Promise.all resolves) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · CRTT: chunk round-trip time (per-chunk write → read latency, one clock domain: deployment → stream backend → same deployment) · CDV: chunk delay variation / delivery jitter (inter-arrival gap minus inter-write gap per seq-adjacent pair; skew-free; the row is each run's MAX positive value, so one stall moves it) Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · Promise.all(100 steps): 100 trivial no-op steps started together in a single Promise.all; Fan-out TTFS is the first of them to complete and Fan-out TTLS the last, both from the in-deployment clientStart, so their gap is the spread the runtime adds across the fan-out · paced control (100/s, 60B): the control: 300 tiny (~60B) deltas metronome-paced at 100/s — zero workload structure, so it reads the transport floor and flush cadence, and disambiguates transport-wide vs workload-specific when a replay row moves · size sweep (100/s, 160B-12KB): same pacing as the control with deltas padded in rotation across seven log-spaced sizes (~160B–12KB) — rotation decouples size from stream position, so it isolates whether chunk size causes latency · replay gateway-gpt-5.4-nano-2000t (1x): raw provider SSE cadence captured at the AI gateway boundary (gpt-5.4-nano, the most popular gateway model; per-token deltas p50 208B = the modal production chunk size), replayed exactly as measured — the typical customer's workload; its CDV is the typical customer's real delivery jitter · replay eve-gpt-5.6-sol-2000t (1x): a captured eve turn (gpt-5.6-sol, the most-used demanding eve model; ~2000 output tokens = production p50 turn length) replayed exactly as measured — eve's envelope protocol re-ships the cumulative message so sizes ramp 142B→13KB; the demanding outlier tenant's reality · replay eve-gpt-5.6-sol-2000t (2x): the same eve capture at 2x — the headroom/stress row; real fast-tier models emit the same chunk sizes at proportionally higher rate, so time compression is a faithful speed model · first chunk (pooled): every run's seq-0 RTT pooled across all stream scenarios — the first chunk precedes any workload differentiation, so pooling samples one shared stream-open path with exact percentiles Replay cadences (semantic sha256) — eve-gpt-5.6-sol-2000t 🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 All timestamps are deployment-side; runs are triggered in-deployment, so the CI runner and api.vercel.com sit outside every measured window. TTFS = Cold starts stay in the numbers (real bursty-workload latency, inflates P75+); Best is the warm floor. |
Sim WorldSimulated world deterministic testing for races. Traces 🟠 world-sim scenario book — 1 fail of 41 total
Full trace: |
Draft. The manual-backport instructions the workflow posts on PRs point at a field the Run workflow dialog does not have, and promise more than a forced dispatch delivers.
What was wrong
1. The input is named by something the UI never shows. Both comments said "paste this commit SHA into the
refinput".refis the input's YAML name; GitHub labelsworkflow_dispatchfields with theirdescription, so no field called "ref" is visible. The one visibly ref-named control in that dialog is "Use workflow from", which picks which branch the workflow file is read from and rejects a raw SHA. Now named by its visible label, with an explicit "not the branch selector".2. "Once the underlying issue is fixed, re-run" is wrong advice when the AI side is the failure. A manual dispatch forces the AI decision to
yes(Decide whether to backportshort-circuits onforce_backport). It does not skip AI conflict resolution:Resolve conflicts with opencodeis gated only onsteps.cherry-pick.outputs.status == 'conflict'. So for a commit that does not apply cleanly, re-dispatching during an AI Gateway outage lands on the identical error.That is exactly what happened. Every
Backport to stablerun since 2026-08-21 18:31 fails withAPI key budget exceeded. Current spend: $10001.21, limit: $10000.00— the push run atDecide whether to backport, and the forced dispatch atResolve conflicts with opencodeafter correctly resolving the pasted SHA and cherry-picking. The comment sent the reader back to a button that could not work.3. The manual recipe was unreachable from an infra failure. It lives in
Comment on conflict failure, which requiresai-resolve.outputs.resolved == 'false'— a step that exited non-zero sets no outputs, so an infra failure never posts it. The failure comment now carries the recipe itself, and lists an out-of-budget key among the likely causes.Verification
Rendered both comment bodies by extracting the
github-scriptblocks and running them against stubbedgithub/context(the YAML-plus-template-literal escaping of backticks and\continuations is the part worth checking, and it comes out correct). All five script blocks in the file still parse.The AI Gateway budget itself is not something this PR fixes: the key needs its limit raised before the workflow can back-port anything that conflicts.
Related: #3718 and #3719 back-port #3406 and #3700 to
stableby hand, which is what the recipe added here describes.