Skip to content

Sort EMV applications by the priority indicator, not the AID #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitjain099 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sort EMV applications by the priority indicator, not the AID #1874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Common/EMVCard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,10 @@ namespace VeraCrypt
if (aidNode && aidNode->Value->size() > 0 && aidPriorityNode && aidPriorityNode->Value->size() == 1)
{
supportedAIDs.push_back(*aidNode->Value.get());
supportedAIDsPriorities.push_back(aidNode->Value->at(0));
// Sort on the Application Priority Indicator, which the line above
// already required to be exactly one byte. Using the AID's first
// byte collapsed every key to 0xA0, the registered provider prefix.
supportedAIDsPriorities.push_back(aidPriorityNode->Value->at(0));
}
}
for(size_t i = 0; i < supportedAIDs.size(); i++)
Expand Down