fix(isVAT): accept Spanish digit controls - #2849
Open
ANONYMOUSZED-beep wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arun <ANONYMOUSZED-beep@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2849 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2599
Branches 658 658
=========================================
Hits 2599 2599 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tux-tn
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2846.
The Spanish VAT matcher currently requires a trailing letter, so it rejects valid legal-entity NIFs whose control character is a digit. It also accepts unassigned entity prefixes and mismatched prefix/control forms.
This change groups Spanish legal-entity prefixes by their permitted control type:
A,B,E,HN,P,Q,R,S,WC,D,F,G,J,U,VRegression coverage includes prefixed and unprefixed digit-control values, letter-control and dual-control forms, plus mismatched controls, unassigned prefixes, and malformed length.
References:
Validation:
npx mocha --require @babel/register --reporter dot --recursive --grep "validate VAT numbers"npx eslint src/lib/isVAT.js test/validators.test.jsnpm test— 323 passing; build and full ESLint includedAI assistance was used to prepare and validate this focused change; the final diff and test results were reviewed before submission.
Checklist