fix: ignore non-object options in isHexColor (#2660)#2661
Open
yuna0831 wants to merge 3 commits intovalidatorjs:masterfrom
Open
fix: ignore non-object options in isHexColor (#2660)#2661yuna0831 wants to merge 3 commits intovalidatorjs:masterfrom
yuna0831 wants to merge 3 commits intovalidatorjs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2661 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2572 2574 +2
Branches 651 652 +1
=========================================
+ Hits 2572 2574 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WikiRik
reviewed
Jan 28, 2026
Member
WikiRik
left a comment
There was a problem hiding this comment.
Shouldn't we add the check to the merge util? That way we cover it for other validators as well. Also; can you add a test for this?
Author
|
Thanks for the suggestion @WikiRik. I've refactored the fix into the merge utility and added a test for the filter use case. All 309 tests passed without linting issues. Ready for another review!" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2660. When isHexColor is used as a callback in Array.prototype.filter, the second argument (index) is passed as the options parameter. This fix ensures options is an object before calling the merge utility.