Skip to content

expr: revert replacement of onig with fancy-regex - #14504

Open
wtcpython wants to merge 1 commit into
uutils:mainfrom
wtcpython:revert-14329-expr-fancy-regex
Open

expr: revert replacement of onig with fancy-regex#14504
wtcpython wants to merge 1 commit into
uutils:mainfrom
wtcpython:revert-14329-expr-fancy-regex

Conversation

@wtcpython

Copy link
Copy Markdown
Contributor

I'm really sorry for the trouble this caused. This reverts #14329 to restore the previous behavior.

Copilot AI lite review requested due to automatic review settings September 11, 2026 12:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@oech3

oech3 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Cannot you contribute to fancy-regex instead? The PR itself does not regress anything yet.
We need to remove oniguruma at some time.

Comment thread Cargo.toml
# libcrypto/libssl dynamically instead, set `OPENSSL_NO_VENDOR=1` at build time.
# `vendored` feature of the `openssl` crate), mirroring how `expr` links
# oniguruma. To link against the system libcrypto/libssl dynamically instead,
# set `OPENSSL_NO_VENDOR=1` at build time.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to revert comments about openssl because it is unrelated.

@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 152.18 MB (-912 KB, -0.58%)

Significant per-binary changes:
  expr     3.65 MB ->    2.76 MB  (-908 KB, -24.30%)

@xtqqczze

Copy link
Copy Markdown
Contributor

@sylvestre Maybe we should consider this for coreutils 0.12. But I think it’s preferable not to revert for now, so we can find more bugs and fix them upstream.

@oech3

oech3 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Unfortunately, many people does not report bugs from non-stable commit...
(Also note that latest-commit is distributing outdated binaries)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@Alonely0

This comment was marked as outdated.

@oech3

This comment was marked as outdated.

@keith-hall

Copy link
Copy Markdown
Contributor

#14527

Comment on lines -267 to -268
/// Transpile the input pattern from BRE syntax to ERE for fancy-regex
fn transpile_bre_to_ere(pattern_str: &str) -> ExprResult<String> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keith-hall Is this not part of fancy-regex yet (does uutils still need it)?

@keith-hall keith-hall Sep 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy-regex doesn't have a parse flag for BRE syntax yet, no, so uutils still needs it

@oech3

oech3 commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Close this PR as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants