expr: revert replacement of onig with fancy-regex - #14504
Conversation
|
Cannot you contribute to fancy-regex instead? The PR itself does not regress anything yet. |
| # libcrypto/libssl dynamically instead, set `OPENSSL_NO_VENDOR=1` at build time. | ||
| # `vendored` feature of the `openssl` crate), mirroring how `expr` links | ||
| # oniguruma. To link against the system libcrypto/libssl dynamically instead, | ||
| # set `OPENSSL_NO_VENDOR=1` at build time. |
There was a problem hiding this comment.
I think we don't need to revert comments about openssl because it is unrelated.
|
Binary size comparison: |
|
@sylvestre Maybe we should consider this for |
|
Unfortunately, many people does not report bugs from non-stable commit... |
|
GNU testsuite comparison: |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| /// Transpile the input pattern from BRE syntax to ERE for fancy-regex | ||
| fn transpile_bre_to_ere(pattern_str: &str) -> ExprResult<String> { |
There was a problem hiding this comment.
@keith-hall Is this not part of fancy-regex yet (does uutils still need it)?
There was a problem hiding this comment.
fancy-regex doesn't have a parse flag for BRE syntax yet, no, so uutils still needs it
|
Close this PR as resolved. |
I'm really sorry for the trouble this caused. This reverts #14329 to restore the previous behavior.