Skip to content

whoami: bypass clap for performance#10851

Closed
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:whoami
Closed

whoami: bypass clap for performance#10851
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:whoami

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Feb 10, 2026

Summary
  whoami-bypass ran
    1.05 ± 0.24 times faster than whoami

@sylvestre
Copy link
Contributor

not sure it is worse the added complexity:

  • the perf diff isn't that important
  • i don't think it is a perf critical command

@oech3
Copy link
Contributor Author

oech3 commented Feb 10, 2026

FILE, --help, and --version only commands are not changed too many times.
So I think this is not too pain to maintain.

An another solution is do that at #4254 instead.

@sylvestre
Copy link
Contributor

another solution is to let it this way ;)
i don't think anyone cares about whoami performances

@oech3
Copy link
Contributor Author

oech3 commented Feb 10, 2026

How about adding fast path to uucore::clap_localization::handle_clap_result(uu_app(), args)?; for all utils?
Then we don't spread many code.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

@sylvestre
Copy link
Contributor

what about we focus first on:

  • GNU compat
  • performance of critical programs like ls, cp, mv, sort, uniq, etc ?
  • the backlog bugs
  • more fuzzers
  • code coverage
  • ...

and come back on micro optimizations later?

@oech3 oech3 closed this Feb 10, 2026
@oech3 oech3 deleted the whoami branch February 10, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants