cksum family: Backport new errors for --binary, --text and --tag #10618

oech3 · 2026-01-31T10:45:01Z

github-actions · 2026-01-31T10:54:10Z

GNU testsuite comparison:

GNU test failed: tests/cksum/b2sum. tests/cksum/b2sum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum. tests/cksum/cksum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-a. tests/cksum/cksum-a is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-base64. tests/cksum/cksum-base64 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-base64-untagged. tests/cksum/cksum-base64-untagged is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-c. tests/cksum/cksum-c is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-raw. tests/cksum/cksum-raw is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-sha3. tests/cksum/cksum-sha3 is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

codspeed-hq · 2026-01-31T10:59:13Z

Merging this PR will not alter performance

✅ 284 untouched benchmarks
⏩ 38 skipped benchmarks¹

_{Comparing oech3:cksum-new (2803f45) with main (8d8e7f8)²}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (8e59663) during the generation of this report, so 8d8e7f8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

github-actions · 2026-01-31T11:30:24Z

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-base64-untagged. tests/cksum/cksum-base64-untagged is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-c. tests/cksum/cksum-c is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-01-31T15:35:01Z

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-c. tests/cksum/cksum-c is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-31T15:57:13Z

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-c. tests/cksum/cksum-c is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

oech3 · 2026-01-31T16:48:45Z

See #10623 . Regression was caused by backport.

oech3 · 2026-01-31T17:26:05Z

from_standalone splitation is painful for clap...

github-actions · 2026-01-31T17:28:44Z

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

src/uu/checksum_common/src/lib.rs

github-actions · 2026-02-01T10:20:11Z

GNU testsuite comparison:

GNU test failed: tests/ls/abmon-align. tests/ls/abmon-align is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

github-actions · 2026-02-01T14:09:01Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-02-01T14:24:26Z

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

github-actions · 2026-02-07T05:04:18Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

ChrisDryden · 2026-02-07T19:09:02Z

Now that the GNU 9.10 is merged this should be passing right?

oech3 · 2026-02-07T19:10:49Z

No. still needed to strip errno from cksum -c...

github-actions · 2026-02-07T19:35:24Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-a is no longer failing!

github-actions · 2026-02-08T12:48:54Z

GNU testsuite comparison:

GNU test failed: tests/pr/bounded-memory. tests/pr/bounded-memory is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cksum/cksum-a is no longer failing!

ChrisDryden · 2026-02-11T10:53:19Z

Surprisingly it seems that the reason cksum-c is failing is because of cat's error parsing not from cksum.

ChrisDryden · 2026-02-11T10:54:14Z

Adding

#[error("{}", strip_errno(.0))]

To line 85 in cat will make that gnu test pass

oech3 · 2026-02-11T10:55:38Z

I think it should be a different PR since it fixes different error.

ChrisDryden · 2026-02-11T11:11:57Z

src/uu/checksum_common/src/lib.rs

+        if tag {
+            return Err(ChecksumError::TagCheck.into());
+        }
+        if binary_flag || text_flag {


I think this check is invalid to have in the checksum_common library since it only applies to cksum and not the other ones like md5sum and sha256sum.

When running on the 9.10 version I'm finding that this is valid:

sha256sum --text --check file

ChrisDryden · 2026-02-11T11:17:56Z

src/uu/checksum_common/src/lib.rs

+    //todo: deduplicate matches.get_flag
+    let text = !matches.get_flag(options::BINARY);
+    let tag = matches.get_flag(options::TAG);
+    let format = OutputFormat::from_standalone(text, tag);


I'm trying to brainstorm to clean this code up and I'm wondering if its better to just pass the matches in the OutputFormat?

Then you can also move the error handling validation into there and it will make the code reduce by a bunch

oech3 · 2026-02-11T11:30:48Z

SInce CI job's queue is filled, I want to avoid rebasing just for cleanup. We can do that later.

github-actions · 2026-02-11T12:14:39Z

GNU testsuite comparison:

GNU test failed: tests/pr/bounded-memory. tests/pr/bounded-memory is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cksum/cksum-a is no longer failing!

github-actions · 2026-02-12T11:43:39Z

GNU testsuite comparison:

GNU test failed: tests/factor/t26. tests/factor/t26 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/t31. tests/factor/t31 is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum-a is no longer failing!
Congrats! The gnu test tests/cksum/cksum-c is no longer failing!

sylvestre · 2026-02-12T11:58:03Z

src/uucore/src/lib/features/checksum/mod.rs

    BinaryTextConflict,
    #[error("--text mode is only supported with --untagged")]
    TextWithoutUntagged,
+    #[error("the --tag option is meaningless when verifying checksums")]


can be done a different pr but it will need translate!() at some point

oech3 · 2026-02-12T11:58:50Z

Is

FAIL: tests/factor/t26
======================

Terminated
FAIL tests/factor/t26.sh (exit status: 124)

FAIL: tests/factor/t31
======================

Terminated
FAIL tests/factor/t31.sh (exit status: 124)

flakey?

sylvestre · 2026-02-12T12:01:55Z

yes, unrelated
i don't know why it is happening lately

oech3 mentioned this pull request Jan 31, 2026

cksum: Backport --text --tag and --binary --tag --untagged fix from GNU's main #10131

Closed

oech3 marked this pull request as draft January 31, 2026 10:55

oech3 force-pushed the cksum-new branch from 59ca37c to 1d91b47 Compare January 31, 2026 11:21

oech3 force-pushed the cksum-new branch 2 times, most recently from c190aaa to 557af54 Compare January 31, 2026 12:13

This comment was marked as resolved.

Sign in to view

oech3 force-pushed the cksum-new branch from 557af54 to decabea Compare January 31, 2026 15:19

oech3 force-pushed the cksum-new branch from decabea to d3ed90d Compare January 31, 2026 15:45

oech3 marked this pull request as ready for review January 31, 2026 16:48

oech3 force-pushed the cksum-new branch 3 times, most recently from f215b6a to fb74f2a Compare January 31, 2026 17:13

oech3 commented Jan 31, 2026

View reviewed changes

src/uu/checksum_common/src/lib.rs Show resolved Hide resolved

RenjiSann force-pushed the cksum-new branch from fb74f2a to a948200 Compare February 1, 2026 10:10

oech3 force-pushed the cksum-new branch from a948200 to 74efafa Compare February 1, 2026 13:57

oech3 force-pushed the cksum-new branch from 74efafa to 6016288 Compare February 1, 2026 14:10

oech3 force-pushed the cksum-new branch from 1f935f2 to 854ba5f Compare February 7, 2026 19:12

oech3 force-pushed the cksum-new branch from 854ba5f to 9d9ecde Compare February 8, 2026 12:40

ChrisDryden reviewed Feb 11, 2026

View reviewed changes

oech3 mentioned this pull request Feb 12, 2026

cat /proc/self/mem does not strip (os error 5) #10884

Closed

ChrisDryden mentioned this pull request Feb 12, 2026

cat: strip errno #10885

Merged

cksum family: New errors for --binary, --text and --tag

2803f45

oech3 force-pushed the cksum-new branch from a31e73e to 2803f45 Compare February 12, 2026 11:28

sylvestre reviewed Feb 12, 2026

View reviewed changes

Uh oh!

cksum family: Backport new errors for --binary, --text and --tag #10618

Are you sure you want to change the base?

cksum family: Backport new errors for --binary, --text and --tag #10618

Conversation

oech3 commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2026

Uh oh!

codspeed-hq bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

github-actions bot commented Jan 31, 2026

Uh oh!

This comment was marked as resolved.

github-actions bot commented Jan 31, 2026

Uh oh!

github-actions bot commented Jan 31, 2026

Uh oh!

oech3 commented Jan 31, 2026

Uh oh!

oech3 commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 7, 2026

Uh oh!

ChrisDryden commented Feb 7, 2026

Uh oh!

oech3 commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 7, 2026

Uh oh!

github-actions bot commented Feb 8, 2026

Uh oh!

ChrisDryden commented Feb 11, 2026

Uh oh!

ChrisDryden commented Feb 11, 2026

Uh oh!

oech3 commented Feb 11, 2026

Uh oh!

ChrisDryden Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

ChrisDryden Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

sylvestre Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 commented Feb 12, 2026

Uh oh!

sylvestre commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

oech3 commented Jan 31, 2026 •

edited

Loading

codspeed-hq bot commented Jan 31, 2026 •

edited

Loading

oech3 commented Jan 31, 2026 •

edited

Loading

oech3 commented Feb 7, 2026 •

edited

Loading