tail: removed precheck that was masking permission errors#10418
Open
frgmntedflower wants to merge 4 commits intouutils:mainfrom
Open
tail: removed precheck that was masking permission errors#10418frgmntedflower wants to merge 4 commits intouutils:mainfrom
frgmntedflower wants to merge 4 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Merging this PR will not alter performance
Comparing Footnotes
|
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10323
tailwas checkingpath.exists()before attempting to open files.This precheck returns
falsefor any metadata error (includingEACCES),causing permission errors to be incorrectly reported as "No such file or directory".
Solution
Removed the
exists()precheck. Nowtailattempts to open the file directly,which allows the OS to report the actual error (e.g., "Permission denied" for
EACCESetc. ).Testing
Tested with the reproduction steps from the issue, the build now reports:
Like the GNU
tail:I also made sure to run it against the testing suit, used
fmtandclippyto check for any issues.Hope that checks out!