Skip to content

TermREPL no longer closes output of host REPL - #2923

Merged
DavyLandman merged 3 commits into
mainfrom
fix/termrepl
Oct 8, 2026
Merged

DavyLandman merged 3 commits into
mainfrom
fix/termrepl

Conversation

@rodinaarssen

Copy link
Copy Markdown
Member
  • TermREPL no longer closes the output writer of the host REPL
  • Fixed a bug in Path creation, preventing nested REPLs starting on Windows machines from starting (a : character in the path is rejected by Path.of)

Fixes #2882

@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 45%. Comparing base (332f6c4) to head (e09f398).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/TermREPL.java 0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2923   +/-   ##
=======================================
- Coverage       45%     45%   -1%     
  Complexity    6813    6813           
=======================================
  Files          844     844           
  Lines        68835   68837    +2     
  Branches     10039   10039           
=======================================
- Hits         31428   31417   -11     
- Misses       35012   35025   +13     
  Partials      2395    2395           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DavyLandman DavyLandman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

@DavyLandman
DavyLandman merged commit eec2d9f into main Oct 8, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested REPL from TermREPL does not return to rascal prompt anymore

2 participants