config: remove fields not documented in config/README.md#191
Open
yushan8 wants to merge 2 commits into
Open
Conversation
This was referenced Jul 13, 2026
yushan8
force-pushed
the
yushan/remove-undocumented-config-fields
branch
from
July 13, 2026 01:41
ebeab02 to
28e274d
Compare
yushan8
marked this pull request as ready for review
July 13, 2026 04:54
liujsj
reviewed
Jul 13, 2026
| if config.Service.MaxWorkerPoolSize <= 0 { | ||
| return nil, fmt.Errorf("service.max_worker_pool_size must be > 0, got %d", config.Service.MaxWorkerPoolSize) | ||
| } | ||
| config.Service.WorkerRootPath = filepath.Join(config.Service.WorkspacesRoot, ".workers") |
There was a problem hiding this comment.
Should we keep this outside of config.go as it is not a field user can provide
yushan8
force-pushed
the
yushan/config-readme-followup
branch
from
July 14, 2026 20:28
a2efb18 to
abe84e5
Compare
yushan8
force-pushed
the
yushan/remove-undocumented-config-fields
branch
from
July 14, 2026 20:30
8e71441 to
4dd57fe
Compare
yushan8
force-pushed
the
yushan/config-readme-followup
branch
from
July 14, 2026 20:33
abe84e5 to
80ed523
Compare
yushan8
force-pushed
the
yushan/remove-undocumented-config-fields
branch
from
July 14, 2026 20:34
4dd57fe to
27cc6f7
Compare
3 tasks
yushan8
force-pushed
the
yushan/remove-undocumented-config-fields
branch
from
July 14, 2026 22:19
27cc6f7 to
67934f9
Compare
3 tasks
yushan8
force-pushed
the
yushan/remove-undocumented-config-fields
branch
from
July 14, 2026 23:10
67934f9 to
06f02e9
Compare
yushan8
force-pushed
the
yushan/config-readme-followup
branch
from
July 14, 2026 23:19
a39ca66 to
b154f1a
Compare
yushan8
force-pushed
the
yushan/remove-undocumented-config-fields
branch
2 times, most recently
from
July 14, 2026 23:40
487e034 to
adf29cc
Compare
Drops RepositoryConfig.FullHashRepos/ExcludedFiles/ExcludeExternalTargets/ StreamBazelLogs and ServiceConfig's settable WorkerRootPath override — none are documented in config/README.md, and WorkerRootPath is now always computed by Parse as workspaces_root_path/.workers rather than optionally overridden. graphrunner/native.go's Bzlmod query construction is adjusted so external-target querying no longer depends on the removed ExcludeExternalTargets field. Also fixes make test-integration on macOS: excludes @bazel_tools's platform-specific files (e.g. a Windows-only test wrapper) from disk-based hashing via RequestOptions.ExtraExcludeFilesRegex, since a prior config-side exclusion (excluded_files) was just removed as undocumented.
…irely
Removes ServiceConfig.WorkerRootPath()/the settable worker_root_path
field along with repomanager.Params.WorkerRootPath — none of it is
documented in config/README.md, and RepoManager already owns
RepoManagerClonePath, so it can derive its own .workers subdirectory
(<repo_manager_clone_path>/.workers/<repo>/worker-{1..N}/) instead of
being handed a second, independently-configurable path for the same
tree.
yushan8
force-pushed
the
yushan/config-readme-followup
branch
from
July 15, 2026 17:44
b154f1a to
6eaa518
Compare
yushan8
force-pushed
the
yushan/remove-undocumented-config-fields
branch
from
July 15, 2026 17:44
adf29cc to
2224a38
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes config fields not documented in config/README.md so the Go structs match the documented surface exactly.
RepositoryConfig.FullHashRepos,ExcludedFiles,ExcludeExternalTargets,StreamBazelLogs, andServiceConfig.WorkerRootPath.graphrunner/native.gonow always includes external targets and no longer applies repo-level full-hash or excluded-file lists (per-request excludes viaRequestOptionsstill work).orchestrator/native_orchestrator.gono longer streams Bazel logs.example/main.goderives the worker checkout path asworkspaces_root/.workersinstead of reading a separate config field.Test plan
make buildmake testStack