Repository navigation
feat(gateway): expose configured queues through ListQueues - #776
Merged
Merged
Conversation
## Summary ### Why? Operators and clients need to discover valid submit queues without already knowing their names or relying on request history, which omits queues that have not received requests. ### What? Add the gateway ListQueues RPC and committed protobuf, gRPC, and YARPC bindings. Reuse queueconfig.Store.List in a transport-agnostic controller that returns a copied, alphabetically sorted list. Wire the RPC into the gateway and expose it through Client.ListQueues and the list-queues CLI command, with one queue name per output line. Cover configured and empty queues, immutable configuration values, error propagation, CLI output and argument validation, and the Docker-backed gateway RPC. ## Test Plan - ✅ `make proto`, `make fmt`, and `make gazelle`. - ✅ Bazel unit tests for the gateway controller, client library, server, server mapper, and CLI (five targets). - ✅ `./tool/bazel test //test/integration/submitqueue/gateway:go_default_test --test_filter='TestGatewayIntegration/TestListQueuesAPI' --strategy=TestRunner=local`; local TestRunner execution allows Docker buildx to update its cache outside the Bazel sandbox. - ✅ `make lint check-gazelle check-tidy`, using a temporary Git index to compare generated output with the candidate changes without committing them first.
behinddwalls
marked this pull request as ready for review
October 5, 2026 20:03
behinddwalls
enabled auto-merge
October 5, 2026 20:05
mnoah1
approved these changes
Oct 5, 2026
behinddwalls
disabled auto-merge
October 5, 2026 22:33
behinddwalls
enabled auto-merge
October 5, 2026 22:34
behinddwalls
temporarily deployed
to
stack-rebase
October 5, 2026 22:44 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Operators and clients need to discover valid submit queues without already knowing their names or relying on request history, which omits queues that have not received requests.
What?
Add the gateway ListQueues RPC and committed protobuf, gRPC, and YARPC bindings. Reuse queueconfig.Store.List in a transport-agnostic controller that returns a copied, alphabetically sorted list. Wire the RPC into the gateway and expose it through Client.ListQueues and the list-queues CLI command, with one queue name per output line.
Cover configured and empty queues, immutable configuration values, error propagation, CLI output and argument validation, and the Docker-backed gateway RPC.
Test Plan
make proto,make fmt, andmake gazelle../tool/bazel test //test/integration/submitqueue/gateway:go_default_test --test_filter='TestGatewayIntegration/TestListQueuesAPI' --strategy=TestRunner=local; local TestRunner execution allows Docker buildx to update its cache outside the Bazel sandbox.make lint check-gazelle check-tidy, using a temporary Git index to compare generated output with the candidate changes without committing them first.