fix(runway): ISS-004 retry transient Git failures - #678
Draft
sbalabanov wants to merge 1 commit into
Draft
Conversation
Summary: Intent: - Prevent temporary Git process and remote failures from being dead-lettered on their first delivery. - Preserve terminal merge-result behavior and fail fast for recognizable permanent Git configuration failures. Changes: - Add structured Git command errors and a centralized Git classifier for retryability and dependency attribution. - Preserve Git process causes through Runway merger wrapping and wire the classifier into the primary consumer. - Cover classifier decisions and verify Runway nacks transient Git failures while rejecting unknown failures. Reproduction: - A merge delivery runs `git fetch origin` or `git push origin ...` while the remote temporarily resets the connection, producing a wrapped `*exec.ExitError`. - Previously Runway registered only generic and MySQL classifiers, so the error stayed non-retryable and the consumer rejected it to the DLQ after one attempt. - With this change the structured Git error is classified as a retryable dependency failure, so the consumer nacks it for redelivery; authentication, invalid repository/configuration, process-start, and unknown command failures remain non-retryable. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Reproduction:
git fetch originorgit push origin ...while the remote temporarily resets the connection, producing a wrapped*exec.ExitError.Generated by the 🪄 pr-create skill in devexp-agent-marketplace
Test Plan
AI Verification
0 issues detected
Skipped validators: claude · EngWiki
Prior runs
Run at
c9ee7a8on Sep 4 22:19 UTC · 14 files · 2s · 0 issues detectedIssues
T3-ISS-004