feat(stovepipe): request history api - entities/mappers - #669
Open
mnoah1 wants to merge 3 commits into
Open
Conversation
Summary: Intent: - Make retained request logs the authority for history availability. - Establish the public and domain projections used by history reads. Changes: - Return not found when no request log records are retained. - Reserve metadata-backed proto fields and add history entity and mapper coverage. - Align the request history RFC with log-only lookup semantics. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
This was referenced Sep 2, 2026
mnoah1
commented
Sep 3, 2026
| // Newer request that caused a superseded state. Empty when not applicable. | ||
| string superseded_by_request_id = 5; | ||
| // Build associated with the occurrence. Empty when no build applies. | ||
| string build_id = 6; |
Contributor
Author
There was a problem hiding this comment.
These haven't been used yet so deleting them here in backwards incompatible way. They're already unused elsewhere in the code/db schema.
mnoah1
changed the title
mnoah1
marked this pull request as ready for review
September 3, 2026 01:03
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
September 3, 2026 01:03
mnoah1
changed the title
sbalabanov
approved these changes
Sep 4, 2026
| // Build associated with the occurrence. Empty when no build applies. | ||
| string build_id = 6; | ||
| // Stable domain reason for a terminal request outcome. Empty otherwise. | ||
| string outcome_reason = 7; |
Contributor
There was a problem hiding this comment.
either change this ordinal to 5 (which will make it a breaking change) or reserve 5 and 6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Stack