adding Radio Thmanyah as Podcast Catcher#568
Open
Yarob50 wants to merge 3 commits intoua-parser:masterfrom
Open
adding Radio Thmanyah as Podcast Catcher#568Yarob50 wants to merge 3 commits intoua-parser:masterfrom
Yarob50 wants to merge 3 commits intoua-parser:masterfrom
Conversation
lbarthon
approved these changes
Jun 6, 2024
| package-lock.json | ||
| *.tgz | ||
| *.log | ||
| .prettierignore |
Member
There was a problem hiding this comment.
unsure about that one, .vscode. makes sense though
| - regex: 'ArcGIS\.Runtime\.(Qt)\.(\d+)\.(\d+)(?:\.(\d+)|)' | ||
| family_replacement: 'ArcGIS Runtime SDK for $1' | ||
|
|
||
| # |
| - regex: '(Radio Thmanyah)/(\d+)\.(\d+)\.(\d+)' | ||
| family_replacement: 'Radio Thmanyah' | ||
| - regex: '(Radio Thmanyah ar)/(\d+)\.(\d+)\.(\d+)' | ||
| family_replacement: 'راديو ثمانية' |
Member
There was a problem hiding this comment.
For consistency, can the family be written in non-utf8 characters? (i.e. why do we need the arabic distinction)
|
|
||
| # Radio Thmanyah Podcast Catcher | ||
| - regex: '(Radio Thmanyah)/(\d+)\.(\d+)\.(\d+)' | ||
| family_replacement: 'Radio Thmanyah' |
Member
There was a problem hiding this comment.
line not needed, as you use a capture group with the same value
| - regex: '(Radio Thmanyah Android)/(\d+)\.(\d+)\.(\d+)' | ||
| family_replacement: 'Radio Thmanyah Android' | ||
| - regex: '(Radio Thmanyah iOS)/(\d+)\.(\d+)\.(\d+)' | ||
| family_replacement: 'Radio Thmanyah iOS' |
Member
There was a problem hiding this comment.
line not needed, as you use a capture group with the same value
| - regex: '(Radio Thmanyah ar)/(\d+)\.(\d+)\.(\d+)' | ||
| family_replacement: 'راديو ثمانية' | ||
| - regex: '(Radio Thmanyah Android)/(\d+)\.(\d+)\.(\d+)' | ||
| family_replacement: 'Radio Thmanyah Android' |
Member
There was a problem hiding this comment.
line not needed, as you use a capture group with the same value
Member
|
You'll also need to fix conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.