mastermind:0.1.0 - #5435
Conversation
|
I will let you fix the CI errors (the warnings about image descriptions can be ignored, these three are fine in practice), and mark the PR as non-draft once you consider it ready for review. I would also appreciate if you could explain where the name comes from, it helps us to judge whether it fits our guidelines or not. |
| - Import the package: | ||
|
|
||
| ```typst | ||
| #import "@preview/class-diagram:0.1.0": * |
There was a problem hiding this comment.
This import needs to be renamed.
| <summary>See the source code</summary> | ||
|
|
||
| ```typ | ||
| #import "@local/class-diagram:0.1.0": * |
| @@ -0,0 +1,54 @@ | |||
| #import "@local/mastermind:0.1.0": * | |||
There was a problem hiding this comment.
For examples, it is preferred to use @preview, so that people can copy/paste them without having to fix anything.
There was a problem hiding this comment.
Actually, you don't link to that file in your README. This makes this file unnecessary for the package to be displayed correctly on Universe, and virtually impossible to find for users. Can you remove the examples/ directory please?
There was a problem hiding this comment.
Same for that file: if you want people to be able to find it from Universe, it has to be linked in your README.
|
Thank you! |
I am submitting
Description: this package let you draw uml diagrams, by also providing theming capabilities for the style. With manual positioning you achieve a nicer result instead of using tools like Mermaid JS, at the same time you don't need to do everything manually like in draw.io for example.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE