IMT-180 Optimize folder asset rendering spec#374
Merged
Conversation
Contributor
nomadicoder
commented
May 6, 2026
nomadicoder
commented
- Move heavy payload assertions out of the system spec
- Keep Wunderbaum browser behavior covered in the system spec
- Verify folder/asset JSON contract in spec/requests/volumes/file_tree_spec.rb
- Test-only change; no production behavior changed
sensei100
reviewed
May 7, 2026
sensei100
requested changes
May 7, 2026
Contributor
sensei100
left a comment
sensei100
left a comment
There was a problem hiding this comment.
One minor change in language
nomadicoder
force-pushed
the
IMT-180-optimize-folder-asset-rendering-spec
branch
from
5ab2d3f to
40fe26c
Compare
…f system spec - Keep spec/system/folder_asset_rendering_spec.rb focused on browser-level Wunderbaum behavior: folder rows render folder affordances, expanding a folder reveals asset rows, and asset rows render asset-specific controls. - Move payload-shape assertions into spec/requests/volumes/file_tree_spec.rb, where they run faster and more directly verify the JSON contract. The request coverage now checks that folder nodes omit asset-only fields, while asset nodes include the fields needed to render asset-only columns. - Test-only change. No production behavior changed. Assertions were added to the existing request spec instead of a new spec file to keep the diff minimal.
nomadicoder
force-pushed
the
IMT-180-optimize-folder-asset-rendering-spec
branch
from
9a2a4d8 to
8cac676
Compare
sensei100
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.