Keep label-only nets out of physical routing#439
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da54f02447
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (labelOnlyNetIds.has(globalNetId)) return true | ||
|
|
||
| const allIds = netConnMap.getIdsConnectedToNet(globalNetId) as string[] | ||
| return allIds.some((id) => labelOnlyNetIds.has(id)) |
There was a problem hiding this comment.
Limit label-only detection to the queried global net
isGlobalNetHandledByLabels marks a net as label-handled when any member ID in that merged connectivity group is a label-enabled net ID, so a mixed group (e.g., direct-connected pins plus one label-enabled alias net) is treated as fully label-only. That causes downstream routing to skip physical pairing for the whole group (MspConnectionPairSolver/LongDistancePairSolver use this predicate), which can drop required traces when only part of the merged net is actually intended to be label-routed.
Useful? React with 👍 / 👎.
Summary
Verification
/claim #79