Skip to content

Keep label-only nets out of physical routing#439

Open
trigga6006 wants to merge 3 commits into
tscircuit:mainfrom
trigga6006:codex/tscircuit-extra-trace-gap
Open

Keep label-only nets out of physical routing#439
trigga6006 wants to merge 3 commits into
tscircuit:mainfrom
trigga6006:codex/tscircuit-extra-trace-gap

Conversation

@trigga6006
Copy link
Copy Markdown

Summary

  • clone direct connectivity before adding netConnections so label-only nets do not mutate direct routing state
  • skip MSP and long-distance physical routing for global nets explicitly handled by available net label orientations
  • add regression coverage for net-label-only pins and refresh affected example snapshots

Verification

  • bun test
  • bunx tsc --noEmit
  • bun run build
  • git diff --check

/claim #79

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
schematic-trace-solver Ready Ready Preview, Comment May 26, 2026 10:46pm

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da54f02447

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if (labelOnlyNetIds.has(globalNetId)) return true

const allIds = netConnMap.getIdsConnectedToNet(globalNetId) as string[]
return allIds.some((id) => labelOnlyNetIds.has(id))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Limit label-only detection to the queried global net

isGlobalNetHandledByLabels marks a net as label-handled when any member ID in that merged connectivity group is a label-enabled net ID, so a mixed group (e.g., direct-connected pins plus one label-enabled alias net) is treated as fully label-only. That causes downstream routing to skip physical pairing for the whole group (MspConnectionPairSolver/LongDistancePairSolver use this predicate), which can drop required traces when only part of the merged net is actually intended to be label-routed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant