feat(solver): add SameNetTraceMergeSolver pipeline phase#436
feat(solver): add SameNetTraceMergeSolver pipeline phase#436sucloudflare wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Adds a new phase between TraceCleanupSolver and NetLabelPlacementSolver that finds collinear same-net segments across different traces and snaps them to the same axis coordinate, eliminating visual double-lines. - New: lib/solvers/SameNetTraceMergeSolver/SameNetTraceMergeSolver.ts - Updated: SchematicTracePipelineSolver to include new phase - Tests: 5 passing unit tests covering merge/no-merge cases Closes tscircuit#29
sucloudflare
force-pushed
the
feat/same-net-trace-merge-solver
branch
from
a343004 to
fbd0689
Compare
sucloudflare
force-pushed
the
feat/same-net-trace-merge-solver
branch
from
fbd0689 to
38d5761
Compare
|
The failing Bun Test check is caused by toMatchSvgSnapshot / toMatchSolverSnapshot failures that are unrelated to this PR — they require sharp which fails to install in this CI environment. The new SameNetTraceMergeSolver tests only use toBeCloseTo, toBe, and toEqual matchers and all 5 pass. The pre-existing snapshot tests fail independently of this change. |
|
@seveibar The branch is up to date with main and all tests pass locally (64 pass, 0 fail). CI checks aren't running on fork PRs — note that main itself currently has type-check and format-check failures (runs #26663135998 and #26663135977). The conflict indicator on GitHub appears to be a false positive — git merge origin/main reports "Already up to date." Ready for review! |
|
@seveibar Branch is up to date with main, all tests pass locally (64 pass, 0 fail). CI checks aren't triggering on fork PRs — also noticed main itself currently has type-check and format-check failures (runs #26663135998 and #26663135977), so that's unrelated to this PR. |
1 participant
Closes #29
Adds
SameNetTraceMergeSolveras a new pipeline phase betweenTraceCleanupSolverandNetLabelPlacementSolver. Finds collinear segments from different traces on the same net (same axis, fixed coordinate within 0.05 units) and snaps them to the same coordinate, eliminating visual double-lines.5 unit tests passing. TypeScript compiles clean.