feat: add SameNetTraceMergerSolver to snap nearly-collinear same-net traces#433
Open
kuaaq wants to merge 19 commits into
Open
feat: add SameNetTraceMergerSolver to snap nearly-collinear same-net traces#433kuaaq wants to merge 19 commits into
kuaaq wants to merge 19 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: SameNetTraceMergerSolver — snap nearly-collinear same-net traces
Closes #34, closes #29
Problem
When multiple traces belong to the same net (e.g. GND), independent routing produces segments with nearly-identical but not exactly-equal coordinates. This creates a visual gap or misalignment on the schematic.
Solution
SameNetTraceMergerSolvergroups traces byglobalConnNetId, compares every segment pair between same-net traces, and snaps collinear overlapping segments (horizontal within Y threshold, vertical within X threshold) to their average coordinate.traceCleanupSolvernetLabelPlacementSolver,example28Solver) updated to consume merged outputFiles changed
lib/solvers/SameNetTraceMergerSolver/SameNetTraceMergerSolver.ts— new solver with_step(),getOutput(), andvisualize()lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts— wired into pipelinetests/same-net-trace-merger.test.ts— 4 unit tests + 1 snapshot testtests/assets/SameNetTraceMerger.test.input.json— snapshot fixture (3-chip GND circuit)Tests
/claim #34
/claim #29