Skip to content

fix(webapp): add eventsource dep back#4274

Closed
carderne wants to merge 1 commit into
mainfrom
fix/eventsource-dep
Closed

fix(webapp): add eventsource dep back#4274
carderne wants to merge 1 commit into
mainfrom
fix/eventsource-dep

Conversation

@carderne

Copy link
Copy Markdown
Collaborator

Removed but local webapp depends on it.

@changeset-bot

changeset-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3c7405d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 67f85120-bb3f-4a94-a0aa-6552ab01cb2e

📥 Commits

Reviewing files that changed from the base of the PR and between d7ec75d and 3c7405d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • apps/webapp/package.json
📜 Recent review details
⏰ Context from checks skipped due to timeout. (6)
  • GitHub Check: sdk-compat / Node.js 20.20 (warp-ubuntu-latest-x64-4x)
  • GitHub Check: sdk-compat / Cloudflare Workers
  • GitHub Check: code-quality / code-quality
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Build and publish previews
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

When adding Zod, use the exact repository-wide pinned version 3.25.76, never a different version or range.

Files:

  • apps/webapp/package.json
apps/webapp/**/package.json

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

For the webapp, never run pnpm run build --filter webapp to verify changes; use pnpm run typecheck --filter webapp after major changes. Public packages under packages/* use build instead.

Files:

  • apps/webapp/package.json
🧠 Learnings (1)
📚 Learning: 2026-04-27T16:46:03.861Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3456
File: apps/webapp/package.json:152-152
Timestamp: 2026-04-27T16:46:03.861Z
Learning: In `apps/webapp/package.json`, treat the `effect` npm package as an intentional runtime dependency (not unused/misplaced) for the Schedule + Fiber-based metadata update logic. This should apply when reviewing `apps/webapp` code paths used by `apps/webapp/app/utils/updateMetadata.server.ts` (and closely related modules) that use Effect APIs such as `Duration.divide`, `STM.cond`, namespace exports for `Effect`/`Schedule`/`Duration`/`Fiber`, and the `Fiber.RuntimeFiber` type.

Applied to files:

  • apps/webapp/package.json
🔇 Additional comments (1)
apps/webapp/package.json (1)

148-148: LGTM!

Also applies to: 205-206


Walkthrough

Updated the webapp dependency manifest to add eventsource version ^3.0.5. The existing tiny-invariant and tw-animate-css entries were reordered without changing their versions.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too brief and misses required template sections like Closes #, Testing, Changelog, and Screenshots. Expand the description to follow the template: add the issue reference, checklist items, testing steps, changelog summary, and screenshots or N/A.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: restoring the eventsource dependency in the webapp.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/eventsource-dep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@3c7405d

trigger.dev

npm i https://pkg.pr.new/trigger.dev@3c7405d

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@3c7405d

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@3c7405d

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@3c7405d

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@3c7405d

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@3c7405d

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@3c7405d

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@3c7405d

commit: 3c7405d

@carderne carderne closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant