feat(supervisor): add per-machine-preset resource request ratios #2906

myftija · 2026-01-19T10:49:32Z

Adds support to configure CPU/memory request ratios per machine preset.
Falls back to the global request ratio configs if no specific override
is specified.

Runs across different machine presets have different usage patters, so
this enables use to manage the available capacity better.

Adds support to configure CPU/memory request ratios per machine preset. Falls back to the global request ratio configs if no specific override is specified. Runs across different machine presets have different usage patters, so this enables use to manage the available capacity better.

changeset-bot · 2026-01-19T10:49:37Z

⚠️ No Changeset found

Latest commit: 38e3e12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-01-19T10:49:50Z

Walkthrough

This pull request adds per-preset override environment variables for Kubernetes CPU and memory request ratios. Fourteen new optional environment variables are introduced to the public Env schema in apps/supervisor/src/env.ts, one for each machine preset size (micro, small_1x, small_2x, medium_1x, medium_2x, large_1x, large_2x) for both CPU and memory overrides. The workload manager in apps/supervisor/src/workloadManager/kubernetes.ts is updated to populate these mappings from environment variables and apply per-preset ratio overrides during resource calculation, with fallback to existing global request ratios if preset-specific values are not set.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the feature and rationale but does not follow the required template structure with explicit sections (Checklist, Testing, Changelog, Screenshots).	Reformat the description to include all required template sections: Checklist, Testing steps, Changelog, and Screenshots sections as specified in the repository template.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and specifically describes the main change: adding per-machine-preset resource request ratios. It is concise, clear, and directly related to the primary objective of the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 72594a4 and 38e3e12.

📒 Files selected for processing (2)

apps/supervisor/src/env.ts
apps/supervisor/src/workloadManager/kubernetes.ts

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

**/*.{ts,tsx}: Always import tasks from @trigger.dev/sdk, never use @trigger.dev/sdk/v3 or deprecated client.defineJob pattern
Every Trigger.dev task must be exported and have a unique id property with no timeouts in the run function

Files:

apps/supervisor/src/workloadManager/kubernetes.ts
apps/supervisor/src/env.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Import from @trigger.dev/core using subpaths only, never import from root

Files:

apps/supervisor/src/workloadManager/kubernetes.ts
apps/supervisor/src/env.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)

**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries

Files:

apps/supervisor/src/workloadManager/kubernetes.ts
apps/supervisor/src/env.ts

**/*.{js,ts,jsx,tsx,json,md,yaml,yml}

📄 CodeRabbit inference engine (AGENTS.md)

Format code using Prettier before committing

Files:

apps/supervisor/src/workloadManager/kubernetes.ts
apps/supervisor/src/env.ts

🧠 Learnings (5)

📓 Common learnings

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Specify machine resources using the `machine` property with preset options like 'large-1x'

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 2150
File: apps/supervisor/src/workloadManager/docker.ts:115-115
Timestamp: 2025-06-04T16:02:22.957Z
Learning: In the Trigger.dev codebase, the supervisor component uses DOCKER_ENFORCE_MACHINE_PRESETS while the docker provider component uses ENFORCE_MACHINE_PRESETS. These are separate components with separate environment variable configurations for the same logical concept of enforcing machine presets.

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Specify machine resources using the `machine` property with preset options like 'large-1x'

Applied to files:

apps/supervisor/src/workloadManager/kubernetes.ts

📚 Learning: 2025-06-04T16:02:22.957Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 2150
File: apps/supervisor/src/workloadManager/docker.ts:115-115
Timestamp: 2025-06-04T16:02:22.957Z
Learning: In the Trigger.dev codebase, the supervisor component uses DOCKER_ENFORCE_MACHINE_PRESETS while the docker provider component uses ENFORCE_MACHINE_PRESETS. These are separate components with separate environment variable configurations for the same logical concept of enforcing machine presets.

Applied to files:

apps/supervisor/src/workloadManager/kubernetes.ts

📚 Learning: 2025-01-13T18:31:48.160Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 1608
File: apps/webapp/app/v3/services/triggerTask.server.ts:418-418
Timestamp: 2025-01-13T18:31:48.160Z
Learning: The `MachinePresetName` schema is used to validate machine preset values in the trigger.dev codebase, ensuring type safety and validation of machine preset options.

Applied to files:

apps/supervisor/src/workloadManager/kubernetes.ts

📚 Learning: 2026-01-15T11:50:06.044Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-15T11:50:06.044Z
Learning: Applies to **/*.{ts,tsx} : Always import tasks from `trigger.dev/sdk`, never use `trigger.dev/sdk/v3` or deprecated `client.defineJob` pattern

Applied to files:

apps/supervisor/src/workloadManager/kubernetes.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)

GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
GitHub Check: typecheck / typecheck
GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (4)

apps/supervisor/src/workloadManager/kubernetes.ts (3)

7-12: LGTM on the updated imports.

The addition of MachinePresetName and PlacementTag types from @trigger.dev/core/v3 is appropriate for the new per-preset mapping feature.

348-363: Fallback logic is well-implemented.

The nullish coalescing operator (??) correctly falls back to the global ratios (this.cpuRequestRatio, this.memoryRequestRatio) when per-preset overrides are not defined. The subsequent clamping logic remains unchanged and properly bounds the computed values.

22-40: Per-preset ratio mappings look correct.

The mappings properly use MachinePresetName as the key type and allow undefined values for optional overrides. The hyphenated preset names (e.g., "small-1x") align with the standard machine preset naming convention. The MachinePresetName type includes all seven presets used in these mappings.

apps/supervisor/src/env.ts (1)

92-109: Well-structured per-preset override configuration.

The new environment variables follow established conventions:

Consistent validation with the global ratios (min(0).max(1))

All overrides are optional, preserving backward compatibility

Clear grouping with explanatory comments

The naming convention (underscores and uppercase) appropriately differs from MachinePresetName (hyphens and lowercase), as environment variables conventionally use SCREAMING_SNAKE_CASE.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vibe-kanban-cloud · 2026-01-19T10:52:32Z

Review Complete

Your review story is ready!

View Story

Comment !reviewfast on this PR to re-generate the story.

nicktrn approved these changes Jan 19, 2026

View reviewed changes

myftija merged commit b7f7d88 into main Jan 19, 2026
33 checks passed

myftija deleted the preset-request-ratios branch January 19, 2026 11:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(supervisor): add per-machine-preset resource request ratios #2906

feat(supervisor): add per-machine-preset resource request ratios #2906

Uh oh!

myftija commented Jan 19, 2026

Uh oh!

changeset-bot bot commented Jan 19, 2026

Uh oh!

coderabbitai bot commented Jan 19, 2026 •

edited

Loading

Uh oh!

vibe-kanban-cloud bot commented Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(supervisor): add per-machine-preset resource request ratios #2906

feat(supervisor): add per-machine-preset resource request ratios #2906

Uh oh!

Conversation

myftija commented Jan 19, 2026

Uh oh!

changeset-bot bot commented Jan 19, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Uh oh!

vibe-kanban-cloud bot commented Jan 19, 2026

Review Complete

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Jan 19, 2026 •

edited

Loading