Fix BUG in graph reverse method & Add needed tests#916
Open
itsamirhn wants to merge 4 commits intotrekhleb:masterfrom
Open
Fix BUG in graph reverse method & Add needed tests#916itsamirhn wants to merge 4 commits intotrekhleb:masterfrom
itsamirhn wants to merge 4 commits intotrekhleb:masterfrom
Conversation
itsamirhn
changed the title
Author
|
Would you please check this PR? @trekhleb |
itsamirhn
force-pushed
the
fix-graph-reverse
branch
from
71b2b0f to
ede3b37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix the issue in #873.
The issue was in the old reverse method, edges reversed one by one and this was making issue for graphs with cycle of length 2. For example, when graph with only two edges AB and BA was reversing, on reversing AB, BA was exist and there will be crash.