Skip to content

Tidy up note package - #271

Open
AlCutter wants to merge 1 commit into
transparency-dev:mainfrom
AlCutter:tidy_note
Open

Tidy up note package#271
AlCutter wants to merge 1 commit into
transparency-dev:mainfrom
AlCutter:tidy_note

Conversation

@AlCutter

Copy link
Copy Markdown
Collaborator

This PR tidies up the note package a bit:

  • Move "common" structs and errors into a new note.go file
  • Add/update top-level NewSigner and NewVerifier functions to natively handle ed25519 keys via the local Signer interface which gives access to the associated verifier.

@AlCutter
AlCutter requested a review from mhutchinson July 31, 2026 19:09
@AlCutter
AlCutter requested a review from a team as a code owner July 31, 2026 19:09
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.85%. Comparing base (fa00c16) to head (24914c6).
⚠️ Report is 182 commits behind head on main.

Files with missing lines Patch % Lines
note/note.go 75.00% 10 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   82.57%   78.85%   -3.73%     
==========================================
  Files           5       10       +5     
  Lines         241      922     +681     
==========================================
+ Hits          199      727     +528     
- Misses         30      108      +78     
- Partials       12       87      +75     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants