Display a continue button when stopped#232
Conversation
| {to ? <RelativeTime from={from} to={to} /> : <RelativeToNow from={from} />} | ||
| </Typography> | ||
| </div> | ||
| <div style={{alignItems: 'center', display: 'flex'}}> |
There was a problem hiding this comment.
Continue should be a icon similar to one in the screenshot from #216
| title="The amount of time between from and to"> | ||
| {to ? <RelativeTime from={from} to={to} /> : <RelativeToNow from={from} />} | ||
| </Typography> | ||
| </div> |
There was a problem hiding this comment.
I don't like the display in the mobile version, maybe we can omit this in the mobile version, so the extra button is only visible in big screen mode?
| </div> | ||
| <div style={{alignItems: 'center', display: 'flex'}}> | ||
| {to ? ( | ||
| <Button |
There was a problem hiding this comment.
Could you make the page a little wider, so that the tags have more space. Maybe something like 1200px instead of 1000px.
|
@jmattheis thanks for the review. I'd prefer not to make broader changes to the frontend design in this PR. This change is intentionally limited to the button itself. I think iconography would be nice as well, but it isn't used for the Start & Stop buttons, so I decided plain text would "fit in" better with the current design. Updates to the design and styling of elements would be better handled in a separate PR (in my opinion). I would rather focus on other issues (#92 ) too |
|
Can this be a setting? I use the continue button but on mobile it would add extra height to timer panel. Maybe it could be put in as an icon button just below the 3-dot menu. Here is a really quick example just from inspect element: |
|
People discussed making this a setting in the original thread (a long time ago, maybe opinions have since changed?) I'll defer making it a setting for now. I'm in favor of updating some design elements too, just not in this change. |
|
I don't want to have changes in traggo that I wouldn't release without further tweaking. So this won't be merged without improving the design.
The start and stop buttons don't really "steal" width from the tag selector. The stop button is later replaced with the end date picker, so it doesn't really matter. With the continue button, most of the time spans with test data, will have multiple lines e.g. Details
vs 
I think this is worse than before, and doesn't really justify having one click less. |
|
What if it just said "START" or "RESUME"? Personally I think it looks good and fits in with the existing material design. HTML elements are intended to split onto a new line when constrained by width, and as a new user I didn't even notice this effect as "being worse". That's just what a responsive ui does. I completely understand that as a long time user, if all your elements suddenly look a bit differently, its a worse experience (or at least, inconvenient) for little/no benefit. I know traggo has a lot more users than me, that's why I haven't made other changes to the UI here. I just want to add this button. It's a common feature request by new users, and I use it all the time in my workflow. |
No.
I disagree.
Yeah, not arguing against this. My main point it that it does linebreak much earlier than before. |
|
Totally fair. Thanks for the review. Cheers! |
3 participants
Relates to #216
This change adds a continue button to the timespan UI, which is only visible when items are not active.