fix: MSSQL connection left in busy state after insert#2171
Merged
abondar merged 4 commits intotortoise:developfrom Apr 7, 2026
Merged
fix: MSSQL connection left in busy state after insert#2171abondar merged 4 commits intotortoise:developfrom
abondar merged 4 commits intotortoise:developfrom
Conversation
7 tasks
Contributor
Author
Member
|
Can you please remove |
Contributor
Author
@abondar this change doesn't work: https://github.com/tortoise/tortoise-orm/actions/runs/24065691084/job/70191195132?pr=2171 According to Claude: |
abondar
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close cursor properly in
ODBCTransactionWrapper.execute_many.Description
We recently see a lot of these errors in MSSQL CI which relies on
pyodbc:bulk_createroutes throughexecute_many, which doesn't close the cursor properly inODBCTransactionWrapper.execute_many. This PR tries to fix that.Motivation and Context
Fix failing CI in MSSQL
How Has This Been Tested?
Run MSSQL in CI and make sure the error doesn't show up.
Checklist: