Skip to content

Answer: 60#1446

Open
tsironis13 wants to merge 2 commits intotomalaforge:mainfrom
tsironis13:angular-async-redirect-challenge
Open

Answer: 60#1446
tsironis13 wants to merge 2 commits intotomalaforge:mainfrom
tsironis13:angular-async-redirect-challenge

Conversation

@tsironis13
Copy link
Contributor

Not sure if distinctUntilChanged() is unnecessary inside the subscription.

@github-actions github-actions bot added 60 async redirect answer answer contributor highly contributing to the project to be reviewed PR requests a review labels Mar 5, 2026
return inject(UserProfileService)
.getProfile()
.pipe(
distinctUntilChanged(),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure that's useful, because the subscription is created on route navigation and removed after

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I will remove it

@tomalaforge tomalaforge removed the to be reviewed PR requests a review label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

60 async redirect answer answer contributor highly contributing to the project to be reviewed PR requests a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants