feat(snowflake)!: transpilation support MAP_PICK #7189
Merged
Conversation
fivetran-ashashankar
requested review from
fivetran-BradfordPaskewitz and
georgesittas
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 4003 total, 4003 passed (pass rate: 100.0%), sqlglot version: sqlglot:RD-1147671-transpile_map_pick: 4003 total, 4003 passed (pass rate: 100.0%), sqlglot version: Transitions: |
fivetran-ashashankar
removed request for
fivetran-BradfordPaskewitz and
georgesittas
fivetran-ashashankar
requested review from
fivetran-BradfordPaskewitz and
georgesittas
geooo109
reviewed
Mar 3, 2026
geooo109
approved these changes
Mar 3, 2026
georgesittas
reviewed
Mar 3, 2026
geooo109
reviewed
Mar 4, 2026
… simplified single args, list and array handled
… simplified single args, list and array handled
geooo109
reviewed
Mar 5, 2026
Comment on lines
+2600
to
+2602
| # Test type inference with array-typed column | ||
| from sqlglot.optimizer import qualify | ||
| from sqlglot.schema import MappingSchema |
Collaborator
There was a problem hiding this comment.
Let's avoid this in the future (importing into function tests).
geooo109
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds transpilation support for Snowflake MAP_PICK to duckdb