refactor: use Imenu as symbol completion source - #484
Draft
tninja wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a436a330d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tninja
force-pushed
the
agent/imenu-symbol-completion
branch
from
August 17, 2026 02:54
18fe046 to
0d77b36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
@file#symbolcompletion so Imenu is the canonical symbol-discovery layer, including when the target buffer is using a Tree-sitter major mode.This keeps the user-facing improvements from #483 (qualified names, source order, header/line annotations) while removing the package-level file-wide Tree-sitter symbol scanner.
Why
#483 treated Imenu and Tree-sitter as alternative symbol providers. In Emacs, Tree-sitter major modes already expose their structural symbol index through Imenu (
treesit-simple-imenu/imenu-create-index-function). Bypassing that abstraction makesai-code-interface.elmaintain a second cross-language symbol-discovery implementation and its own function/method/constructor node-type registry.There is one important nuance: Tree-sitter-backed Imenu indexes are often grouped into flat categories such as
ClassandFunction, so Imenu alone does not always preserve the enclosing-type path needed forBar.baz.Changes
imenu--make-index-alistas the single source of which symbols exist and their source positions.Class/Functionas name prefixes.Bar.bazandOuter.Inner.run.Design
The abstraction is now:
major mode (Tree-sitter / regexp / LSP / mode-specific) -> Imenu -> ai-code symbol discoverywith Tree-sitter used only as position-local enrichment when an active parser can provide metadata that the Imenu representation omitted.
In particular, this PR does not scan the file-wide Tree-sitter AST to rediscover symbols and does not maintain a new cross-language function/method node-type table.
Validation
Bar.bazandOuter.Inner.run.