Open
Conversation
This commit removes support for Cucumber v1.3. The last release of Cucumber v1.3 was nearly 10 years ago: https://github.com/cucumber/cucumber-ruby/releases/tag/v1.3.20 It's hard to imagine anyone using such an old version of Cucumber with test-queue in 2025. I’m also working on adding Ruby 3.4 support to CI for test-queue, but running test-queue with Cucumber v1.3 on Ruby 3.4 is problematic: #1 Given these factors, I think it’s reasonable to drop support for Cucumber v1.3.
S-H-GAMELINKS
commented
May 14, 2025
| runtime.send(:summary_report).test_cases.total_failed | ||
| else | ||
| runtime.results.scenarios(:failed).size | ||
| end |
Contributor
Author
There was a problem hiding this comment.
This conditional branch was specifically needed to support Cucumber v1.3.
Since support for that version has been removed, this code is no longer necessary.
Owner
|
I don't have a strong preference but there appears to be a release planned with ruby 3.4 support cucumber/cucumber-ruby#1785 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes support for Cucumber v1.3.
The last release of Cucumber v1.3 was nearly 10 years ago: https://github.com/cucumber/cucumber-ruby/releases/tag/v1.3.20 It's hard to imagine anyone using such an old version of Cucumber with test-queue in 2025.
I’m also working on adding Ruby 3.4 support to CI for test-queue, but running test-queue with Cucumber v1.3 on Ruby 3.4 is problematic: S-H-GAMELINKS#1
Given these factors, I think it’s reasonable to drop support for Cucumber v1.3.