os: add File.Chown on the unix path - #5589
Merged
Merged
Conversation
b0ch3nski
reviewed
Aug 14, 2026
| } | ||
|
|
||
| // Chown changes the numeric uid and gid of the named file. It mirrors Truncate: | ||
| // the unix os.File was missing this method (it exists only on the baremetal/wasm |
Contributor
There was a problem hiding this comment.
IMO the history of the change is not necessary to stay as a code comment when its not relevant to the implementation
Member
There was a problem hiding this comment.
I agree. Please change the comment to simply document os.Chown.
file_unix.go (darwin/linux/wasip) was missing the exported (*File).Chown method that file_other.go (baremetal/wasm) already has, so callers requiring the full os.File surface — e.g. github.com/pkg/sftp — failed to compile for the linux/amd64 TinyGo target. Delegates to the package-level Chown, mirroring (*File).Truncate.
Contributor
Author
|
Thanks both — comment reduced to documenting the method, matching the wording of the package-level |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.File.Chownis missing on unix targets, so code calling it fails to compile even thoughos.Chown(the path-based form) is present and the syscall is already available.This adds the method on the unix path, delegating to the same syscall the package-level function uses.
Verified by building TinyGo.