Append GatewayNamespace deployment mode processing#4658
Open
radixo wants to merge 3 commits intotigera:masterfrom
Open
Append GatewayNamespace deployment mode processing#4658radixo wants to merge 3 commits intotigera:masterfrom
radixo wants to merge 3 commits intotigera:masterfrom
Conversation
radixo
force-pushed
the
gatewayapi-deployment-resources
branch
from
9743e9d to
081eda0
Compare
- Add GatewayDeploymentMode type with ControllerNamespace and GatewayNamespace options - Default to ControllerNamespace when not specified in the controller Reconcile - Regenerate CRD manifest and deepcopy methods
- Replace build-time helm template with embedded .tgz chart rendered at runtime using the Helm SDK, aligning with the Istio pattern - Pass config.envoyGateway.provider.kubernetes.deploy.type as a helm value when GatewayDeploymentMode is GatewayNamespace - Clean up mode-specific resources (ClusterRole, ClusterRoleBinding) when switching between deployment modes - Remove 3.3MB pre-rendered YAML from git tracking; the .tgz chart (450KB) is gitignored and downloaded at build time like Istio charts
radixo
force-pushed
the
gatewayapi-deployment-resources
branch
from
081eda0 to
c30e1b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Embed Envoy Gateway helm chart and render at runtime.
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.