Conversation
❌ Deploy Preview for calico-docs-preview-next failed. Why did it fail? →
|
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Upgrades the documentation site’s Docusaurus toolchain to 3.10, including associated lockfile updates and configuration changes to enable the newer future flags.
Changes:
- Bump Docusaurus packages from
3.9.2to3.10.0inpackage.json. - Refresh
yarn.lockto match the upgraded Docusaurus dependency graph (notably newer DocSearch and Rspack-related packages). - Update
docusaurus.config.jsto use the newerfuture.v4andfuture.fasterconfiguration blocks.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
package.json |
Updates Docusaurus dependency versions to ^3.10.0. |
yarn.lock |
Locks updated dependency tree resulting from the Docusaurus upgrade. |
docusaurus.config.js |
Migrates future configuration to the newer Docusaurus 3.10 structure and enables additional faster options. |
| const config = { | ||
| future: { | ||
| experimental_faster: { | ||
| v4: { | ||
| removeLegacyPostBuildHeadAttribute: true, | ||
| useCssCascadeLayers: true, |
There was a problem hiding this comment.
The new future block is mis-indented (v4: is not aligned under future:), which breaks the file’s consistent 2-space formatting and makes the config harder to scan. Please reformat this block so keys are consistently indented.
| mdx1CompatDisabledByDefault: true, | ||
| }, | ||
| faster: { | ||
| swcJsLoader: true, | ||
| swcJsMinimizer: true, |
There was a problem hiding this comment.
The new future block is also mis-indented for the faster: key (extra/missing leading spaces compared to surrounding keys). Please reformat so faster: aligns with v4: and other properties under future:.
| @@ -37,12 +37,12 @@ | |||
| "@chakra-ui/theme-tools": "2.2.6", | |||
| "@crawlee/utils": "^3.13.10", | |||
| "@docsearch/react": "^3.9.0", | |||
There was a problem hiding this comment.
@docusaurus/theme-search-algolia@3.10.0 pulls in @docsearch/react@4.x, but this repo still pins @docsearch/react to ^3.9.0. That results in two major versions of DocSearch being installed (see yarn.lock entries for 3.9.0 and 4.6.2), which can increase bundle size and risks API/style mismatches for the custom SearchBar. Consider aligning the direct dependency to the 4.x range used by Docusaurus (or removing the direct dependency if it’s no longer needed) and verifying the custom src/theme/SearchBar continues to work.
| "@docsearch/react": "^3.9.0", | |
| "@docsearch/react": "^4.6.2", |
Product Version(s):
Issue:
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: