Use Octokit instead of calling gh#9
Merged
Merged
Conversation
neilvcarvalho
force-pushed
the
nc/octokit
branch
6 times, most recently
from
64e1510 to
45a21e8
Compare
We're calling `gh` directly, which needs a lot of extra set up to test the action. GitHub has its own gem that wraps its API, `octokit`. It's much easier to test `octokit` calls instead of a CLI. This commit swaps the shell-based GhClient for one backed by the octokit gem. `GithubClient` now takes `token` and an optional `client` instead of `runner`. The exe reads `GITHUB_TOKEN` and passes it through.
This action has its own Ruby dependencies that may or may not be included in the consumer Gemfile. To avoid colliding dependencies, we should run within the same Ruby setup as the consumer application, but run our own `bundle install`, running anything that redirects to the consumer application using `Bundler.with_unbundled_env` to opt out of our Gemfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.