[SKIP SOF-TEST] .github:: add pull request workflow for Zephyr shell builds#10763
Merged
Conversation
Collaborator
Author
|
As expected, test fails without the fix that is part of #10621 |
kv2019i
requested review from
abonislawski,
iuliana-prodan and
lyakh
as code owners
Collaborator
Author
|
V2 pushed:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new GitHub Actions workflow to ensure Zephyr builds with SOF shell support enabled keep working across key Intel platforms, catching shell-overlay regressions on every pull request.
Changes:
- Introduce a new
Zephyr Shellworkflow triggered onpull_requestandworkflow_dispatch. - Build Zephyr targets for
tgl,mtl, andlnlusingsof/app/shell_overlay.confwith warnings treated as errors.
Collaborator
Author
|
Now passing the newly added test (with the fix cherry-picked)! |
Add zephyr-shell.yml GitHub Actions workflow that builds Intel 'tgl', 'mtl' and 'lnl' platforms with Zephyr shell support enabled via: --overlay=sof/app/shell_overlay.conf This catches regressions in shell-enabled builds on every pull request. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
In file included from /home/lrg/work/sof2/sof/zephyr/sof_shell.c:14:
/home/lrg/work/sof2/sof/zephyr/sof_shell.c: In function 'cmd_sof_module_heap_usage':
/home/lrg/work/sof2/sof/zephyr/sof_shell.c:66:77: error: 'struct module_config' has no member named 'heap_bytes'
66 | icd->id, usage, hwm, comp_mod(icd->cd)->priv.cfg.heap_bytes);
| ^
/home/lrg/work/sof2/zephyr/include/zephyr/shell/shell.h:1292:47: note: in definition of macro 'shell_print'
1292 | shell_fprintf_normal(_sh, _ft "\n", ##__VA_ARGS__)
| ^~~~~~~~~~~
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202605-ci-zephyr-shell
branch
from
fb88206 to
3c98c48
Compare
Collaborator
Author
|
V3:
|
lgirdwood
approved these changes
May 11, 2026
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Incidentally I have pipeline construction shell commands now working...
Member
|
Not tested by internal CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add zephyr-shell.yml GitHub Actions workflow that builds Intel 'tgl', 'mtl' and 'lnl' platforms with Zephyr shell support enabled via:
--overlay=sof/app/shell_overlay.conf
This catches regressions in shell-enabled builds on every pull request.