fix an integer-driven out-of-bounds memory read vulnerability in DartsCloneTrieWrapper - #1550
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_977902657
branch
3 times, most recently
from
September 9, 2026 13:26
0dfd37f to
49c9ef3
Compare
…sCloneTrieWrapper Refactored the API surface across DartsCloneTrieWrapper, FastBertNormalizer, and OnePassNormalizer to avoid passing explicit integer size arguments (size_t/int), accepting absl::Span<const uint32_t> instead so bounds are automatically inferred from containers (std::vector, std::array, absl::FixedArray, and FlatBuffers flatbuffers::Vector). PiperOrigin-RevId: 978509649
copybara-service
Bot
force-pushed
the
test_977902657
branch
from
September 9, 2026 13:27
49c9ef3 to
65fbcfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix an integer-driven out-of-bounds memory read vulnerability in DartsCloneTrieWrapper
Refactored the API surface across DartsCloneTrieWrapper, FastBertNormalizer, and OnePassNormalizer to avoid passing explicit integer size arguments (size_t/int), accepting absl::Span instead so bounds are automatically inferred from containers (std::vector, std::array, absl::FixedArray, and FlatBuffers flatbuffers::Vector).