Removes enableScalarColumnContextMenus flag#6809
Open
hoonji wants to merge 1 commit intotensorflow:masterfrom
Open
Removes enableScalarColumnContextMenus flag#6809hoonji wants to merge 1 commit intotensorflow:masterfrom
hoonji wants to merge 1 commit intotensorflow:masterfrom
Conversation
bmd3k
approved these changes
Mar 28, 2024
| parseValue: parseBoolean, | ||
| }, | ||
| enableScalarColumnContextMenus: { | ||
| defaultValue: false, |
Contributor
There was a problem hiding this comment.
The preferred way to do this would have been to set defaultValue: true.
That way rolling it back is very slightly more straightforward - greater chance of avoiding merge conflicts and having a clean rollback commit.
And then delete the code, say, one or two weeks later?
But I leave that up to you to decide which way to go.
Member
Author
There was a problem hiding this comment.
Whoops sorry I see now that your request in the email was just to set the defaultValue.
I'll send another PR for the defaultValue update and we can just apply this PR later when everything looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Context menus in Time series scalar tables are ready for use!
Technical description of changes
Removes the enableScalarColumnContextMenus feature flag and associated code
Detailed steps to verify changes work correctly (as executed by you)
Manually tested context menus in runs table, filterbar, scalar tables