Skip to content

Conversation

@kenya-sk
Copy link
Contributor

@kenya-sk kenya-sk commented Feb 8, 2026

This PR addresses various Pylint errors in the benchmarks/ directory to ensure CI compliance and improve code quality. The changes include fixing import paths, enforcing naming conventions, and modernizing Python syntax.

  • Fix Imports:
    • Converted relative imports to absolute imports (e.g., benchmarks.scripts...) and resolved test_log_pb2 import issues. Grouped imports to fix wrong-import-order and ungrouped-imports errors.
  • Style & Formatting:
    • Renamed TEST_FLAGS to test_flags and converted test method names to snake_case (e.g., test_benchmark_gradient) to comply with PEP8 naming conventions.
    • Wrapped long lines and docstrings to satisfy the 80-character line length limit.
  • Documentation:
    • Added missing module and function docstrings.
  • Refactoring:
    • Updated super() calls to the cleaner Python 3 syntax (super().init()).

@mhucka mhucka added area/health Involves general matters of project configuration, health, maintenance, and similar concerns area/python Involves Python code labels Feb 9, 2026
@mhucka mhucka changed the title Fix pylint error in benchmark directory Fix pylint errors in benchmark directory Feb 10, 2026
@mhucka mhucka self-assigned this Feb 10, 2026
@mhucka
Copy link
Member

mhucka commented Feb 10, 2026

@kenya-sk Thank you for this work and the PR. This all looks good; however, because we're in the middle of getting release 0.7.6 done, I will hold off on merging this until after the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/health Involves general matters of project configuration, health, maintenance, and similar concerns area/python Involves Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants