Merged
Conversation
stephanos
force-pushed
the
slim-jobs
branch
6 times, most recently
from
1a5f710 to
ea0720a
Compare
stephanos
commented
Feb 4, 2026
stephanos
force-pushed
the
slim-jobs
branch
23 times, most recently
from
5a96985 to
07c7788
Compare
stephanos
commented
Feb 5, 2026
stephanos
force-pushed
the
slim-jobs
branch
15 times, most recently
from
151e888 to
7460eec
Compare
stephanos
commented
Feb 6, 2026
Comment on lines
+63
to
+65
| # Check for test-all-dbs label | ||
| elif echo '${{ toJson(github.event.pull_request.labels.*.name) }}' | jq -e 'any(. == "test-all-dbs")' > /dev/null 2>&1; then | ||
| FULL_TEST_REASON="Running full tests on all DBs (test-all-dbs label)." |
Contributor
Author
There was a problem hiding this comment.
This is the escape catch.
stephanos
commented
Feb 9, 2026
| TEST_TOTAL_SHARDS: ${{ matrix.total_shards }} | ||
| TEST_SHARD_INDEX: ${{ matrix.total_shards && matrix.shard_index }} # guard with total_shards to avoid falsy eval of shard_index=0 | ||
| TEST_SHARD_SALT: ${{ vars.TEST_SHARD_SALT || '-salt-26' }} | ||
| TEST_ARGS: ${{ matrix.test_args }} |
Contributor
Author
There was a problem hiding this comment.
Needed for smoke tests that set their own -run
stephanos
commented
Feb 9, 2026
| # Check for persistence code changes | ||
| elif [[ -n "$merge_base" ]]; then | ||
| echo "Changed persistence files:" | ||
| git diff --name-only "$merge_base" "$COMMIT" | grep -E "^(common/persistence/|schema/)" || echo "(none)" |
Contributor
Author
There was a problem hiding this comment.
This makes sure changes to persistence are fully tested.
stephanos
commented
Feb 10, 2026
| if: ${{ !cancelled() }} | ||
| with: | ||
| name: junit-xml--${{github.run_id}}--${{ steps.get_job_id.outputs.job_id }}--${{github.run_attempt}}--${{matrix.name}}--shard${{matrix.shard_index}}--functional-test | ||
| name: junit-xml--${{ github.run_id }}--${{ steps.get_job_id.outputs.job_id }}--${{ github.run_attempt }}--${{ matrix.name }}--${{ matrix.display_name }}--functional-test |
Contributor
Author
There was a problem hiding this comment.
display_name contains shard for sharded jobs
stephanos
commented
Feb 10, 2026
| cmd: make functional-test-coverage | ||
| test_timeout: 5m | ||
| github_timeout: 10 | ||
| test_args: '"-run=TestActivityTestSuite|TestSignalWorkflowTestSuite|TestWorkflowTestSuite"' |
Contributor
Author
There was a problem hiding this comment.
Note the double quotation; required for Makefile to prevent interpretation of |.
stephanos
commented
Feb 10, 2026
| persistence_type: nosql | ||
| persistence_driver: cassandra | ||
| containers: [cassandra, elasticsearch] | ||
| arch: arm |
Contributor
Author
There was a problem hiding this comment.
Using ARM here now.
stephanos
commented
Feb 10, 2026
| persistence_type: sql | ||
| persistence_driver: postgres12 | ||
| containers: [postgresql] | ||
| arch: arm |
Contributor
Author
There was a problem hiding this comment.
Using ARM here now.
KeithB-Temporal
approved these changes
Feb 12, 2026
Contributor
KeithB-Temporal
left a comment
KeithB-Temporal
left a comment
There was a problem hiding this comment.
Changes look good to me.
yux0
approved these changes
Feb 12, 2026
# Conflicts: # .github/workflows/run-tests.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Running an abridged database coverage (unless on main/release branch or touching persistence)
Why?
Reduce PR failure rate by not running tests for every database setup.
Note that an earlier version of this PR also merged
xdcandndcwith the other tests across shards but there were a couple of issues (e.g. xdc and ndc are not shard aware) that we'll address later.How did you test it?
Abridged run: https://github.com/temporalio/temporal/actions/runs/21849078475/job/63051453069
(note smoke test)
Full run: https://github.com/temporalio/temporal/actions/runs/21846314222/job/63043110945